Fix incorrect parsing of headers containing equal character

[Theo024]

SUMMARY

Fix mail header parsing that skip headers containing equals characters due to missing maxsplit on header key/value parsing.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

mail module

ADDITIONAL INFORMATION

For example, the following mail module invocation trigger the bug:

- name: Send email
  mail:
    host: "{{ smtp.host }}"
    port: "{{ smtp.port }}"
    secure: "{{ smtp.secure }}"
    username: "{{ smtp.username }}"
    password: "{{ smtp.password }}"
    subtype: "html"
    from: "{{ email.from }}"
    to: "{{ to }}"
    subject: "{{ subject }}"
    body: "{{ body }}"
    attach: "{{ email.attach | default(omit) }}"
    headers:
      - X-Protective-Marking="VER=2005.6, NS=2020.1.example.com, SEC=xfkrf, ORIGIN=noreply@example.com"

The split("=") function applied to split the header key and value generate an error because there are multiples = characters, but only 2 output values are expected. Adding a maxsplit of 1 to the split fix the behavior and extract correctly the header key and value.

[ansibullbot]

cc @dagwieers
click here for bot help

[felixfontein]

Thanks for your contribution! I have one comment for the changelog fragment, besides that this is good!

[patchback]

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/f4237dde1bd0093438705edd52006cc40470dc45/pr-7303

Backported as #7305

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[felixfontein]

@Theo024 thanks a lot for your contribution!

[patchback]

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/f4237dde1bd0093438705edd52006cc40470dc45/pr-7303

Backported as #7306

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.