Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community.general.make: #7180

Merged
merged 7 commits into from
Sep 6, 2023
Merged

community.general.make: #7180

merged 7 commits into from
Sep 6, 2023

Conversation

snail59
Copy link
Contributor

@snail59 snail59 commented Aug 31, 2023

allows to use parameters with empty value in community.general.make.

SUMMARY

Currently, params with empty value get set as None, which is not useful and can lead to unexpected behavior.

fixes #7178

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

make

ADDITIONAL INFORMATION

Currently this code, used to build freebsd from sources:

community.general.make:
  target: buildworld
  chdir: "{{ freebsd_src_dir }}"
  params:
    -DWITH_FDT:
    TARGET: arm64

produces make -DWITH_FDT=None TARGET=arm64 while make -DWITH_FDT TARGET=arm64 is expected.
Note the absence of "=None" for -DWITH_FDT.

@snail59
community.general.make:
dfde394 
  allows parameters without value

  closes #7178
@ansibullbot
Copy link
Collaborator

cc @LinusU
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Aug 31, 2023
@ansibullbot ansibullbot removed the small_patch Hopefully easy to review label Aug 31, 2023
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI and removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Aug 31, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Aug 31, 2023
felixfontein
felixfontein reviewed Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! How about adding an example in EXAMPLES that shows how this works?

changelogs/fragments/7180-make_params_without_value.yml Outdated Show resolved Hide resolved
felixfontein
felixfontein approved these changes Sep 3, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll merge this in a couple of days if nobody objects.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Sep 6, 2023
@felixfontein felixfontein merged commit 9021e74 into ansible-collections:main Sep 6, 2023
@patchback
Copy link

patchback bot commented Sep 6, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/9021e7416d66d3853c4be655b2d54a13f7f7af21/pr-7180

Backported as #7217

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@snail59 thanks for your contribution!

patchback bot pushed a commit that referenced this pull request Sep 6, 2023
@snail59 @patchback
community.general.make: (#7180)
8cc8999 
* community.general.make:

  allows parameters without value

  closes #7178

* add changelog fragment for community.general.make

* correction: v != none -> v is not None

* update fragment changelog as per developer request

* add an example

* document the modification

* update example with comments as per maintainer request

(cherry picked from commit 9021e74)
@patchback patchback bot mentioned this pull request Sep 6, 2023
Merged
@patchback
Copy link

patchback bot commented Sep 6, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/9021e7416d66d3853c4be655b2d54a13f7f7af21/pr-7180

Backported as #7218

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 6, 2023
@snail59 @patchback
community.general.make: (#7180)
3a5e79d 
* community.general.make:

  allows parameters without value

  closes #7178

* add changelog fragment for community.general.make

* correction: v != none -> v is not None

* update fragment changelog as per developer request

* add an example

* document the modification

* update example with comments as per maintainer request

(cherry picked from commit 9021e74)
@patchback patchback bot mentioned this pull request Sep 6, 2023
Merged
felixfontein pushed a commit that referenced this pull request Sep 6, 2023
@patchback @snail59
[PR #7180/9021e741 backport][stable-7] community.general.make: (#7218)
46d454e 
community.general.make: (#7180)

* community.general.make:

  allows parameters without value

  closes #7178

* add changelog fragment for community.general.make

* correction: v != none -> v is not None

* update fragment changelog as per developer request

* add an example

* document the modification

* update example with comments as per maintainer request

(cherry picked from commit 9021e74)

Co-authored-by: snail59 <25689269+snail59@users.noreply.github.com>
felixfontein added a commit that referenced this pull request Sep 7, 2023
@patchback @snail59 @felixfontein
[PR #7180/9021e741 backport][stable-6] community.general.make: (#7217)
5707fc1 
* community.general.make: (#7180)

* community.general.make:

  allows parameters without value

  closes #7178

* add changelog fragment for community.general.make

* correction: v != none -> v is not None

* update fragment changelog as per developer request

* add an example

* document the modification

* update example with comments as per maintainer request

(cherry picked from commit 9021e74)

* Avoid semantic markup for stable-6.

---------

Co-authored-by: snail59 <25689269+snail59@users.noreply.github.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
etrombly pushed a commit to etrombly/community.general that referenced this pull request Oct 25, 2023
@snail59
community.general.make: (ansible-collections#7180)
484ff78 
* community.general.make:

  allows parameters without value

  closes ansible-collections#7178

* add changelog fragment for community.general.make

* correction: v != none -> v is not None

* update fragment changelog as per developer request

* add an example

* document the modification

* update example with comments as per maintainer request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

community.general.make params without value
3 participants
@snail59 @ansibullbot @felixfontein