Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ejabberd_user: better error when command not installed #7028

Merged

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Jul 29, 2023

SUMMARY

When the ejabberdctl command is not found, throws a more meaningful error message indicating so. Previously the message made no mention to the root of the problem.

Fixes #6949

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/ejabberd_user.py

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module plugins plugin (any type) small_patch Hopefully easy to review labels Jul 29, 2023
@ansibullbot ansibullbot removed the small_patch Hopefully easy to review label Jul 29, 2023
@felixfontein felixfontein merged commit 3a7044e into ansible-collections:main Jul 29, 2023
@patchback
Copy link

patchback bot commented Jul 29, 2023

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/3a7044e2b85a6452c90d492505d9b7b18c70cef6/pr-7028

Backported as #7029

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@russoz thanks!

patchback bot pushed a commit that referenced this pull request Jul 29, 2023
* ejabberd_user: better error when command not installed

* add changelog frag

(cherry picked from commit 3a7044e)
@patchback
Copy link

patchback bot commented Jul 29, 2023

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/3a7044e2b85a6452c90d492505d9b7b18c70cef6/pr-7028

Backported as #7030

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 29, 2023
* ejabberd_user: better error when command not installed

* add changelog frag

(cherry picked from commit 3a7044e)
felixfontein pushed a commit that referenced this pull request Jul 29, 2023
…en command not installed (#7029)

ejabberd_user: better error when command not installed (#7028)

* ejabberd_user: better error when command not installed

* add changelog frag

(cherry picked from commit 3a7044e)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
felixfontein pushed a commit that referenced this pull request Jul 29, 2023
…en command not installed (#7030)

ejabberd_user: better error when command not installed (#7028)

* ejabberd_user: better error when command not installed

* add changelog frag

(cherry picked from commit 3a7044e)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
@russoz russoz deleted the 6949-ejabberctrl-missing branch July 29, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug module module plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

community.general.ejabberd_user should report not installed
3 participants