Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proxmox_kvm] Don't create VM if name is used without vmid #6981

Conversation

UnderGreen
Copy link
Contributor

SUMMARY

Fixes #6911

While creating VM by using name only we check if VM with that name already exist and cluster and do nothing in that case.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

proxmox_kvm

ADDITIONAL INFORMATION

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module plugins plugin (any type) labels Jul 20, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Jul 20, 2023
@UnderGreen UnderGreen marked this pull request as draft July 20, 2023 16:05
@ansibullbot ansibullbot added the WIP Work in progress label Jul 20, 2023
@UnderGreen UnderGreen force-pushed the proxmox/unique-name-if-no-vmid branch from 5ca3296 to d4cef88 Compare July 21, 2023 01:00
@ansibullbot ansibullbot added tests tests unit tests/unit labels Jul 21, 2023
@UnderGreen UnderGreen marked this pull request as ready for review July 21, 2023 01:38
@ansibullbot ansibullbot removed the WIP Work in progress label Jul 21, 2023
@felixfontein
Copy link
Collaborator

Looks good to me. I'll merge in a couple of days if nobody objects.

@felixfontein felixfontein merged commit f944857 into ansible-collections:main Jul 23, 2023
@patchback
Copy link

patchback bot commented Jul 23, 2023

Backport to stable-6: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply f944857 on top of patchback/backports/stable-6/f9448574bd43611d71932f0d88bc67585d528f2f/pr-6981

Backporting merged PR #6981 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible-collections/community.general.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-6/f9448574bd43611d71932f0d88bc67585d528f2f/pr-6981 upstream/stable-6
  4. Now, cherry-pick PR [proxmox_kvm] Don't create VM if name is used without vmid #6981 contents into that branch:
    $ git cherry-pick -x f9448574bd43611d71932f0d88bc67585d528f2f
    If it'll yell at you with something like fatal: Commit f9448574bd43611d71932f0d88bc67585d528f2f is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x f9448574bd43611d71932f0d88bc67585d528f2f
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR [proxmox_kvm] Don't create VM if name is used without vmid #6981 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-6/f9448574bd43611d71932f0d88bc67585d528f2f/pr-6981
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jul 23, 2023
@patchback
Copy link

patchback bot commented Jul 23, 2023

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/f9448574bd43611d71932f0d88bc67585d528f2f/pr-6981

Backported as #6992

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@UnderGreen thanks a lot!

patchback bot pushed a commit that referenced this pull request Jul 23, 2023
* [proxmox_kvm] Don't create VM if name is used without vmid

* Add changelog and unit tests

(cherry picked from commit f944857)
felixfontein pushed a commit that referenced this pull request Jul 23, 2023
…if name is used without vmid (#6992)

[proxmox_kvm] Don't create VM if name is used without vmid (#6981)

* [proxmox_kvm] Don't create VM if name is used without vmid

* Add changelog and unit tests

(cherry picked from commit f944857)

Co-authored-by: Sergei Antipov <greendayonfire@gmail.com>
@UnderGreen UnderGreen deleted the proxmox/unique-name-if-no-vmid branch July 24, 2023 02:37
UnderGreen added a commit to UnderGreen/community.general that referenced this pull request Jul 24, 2023
…ollections#6981)

* [proxmox_kvm] Don't create VM if name is used without vmid

* Add changelog and unit tests

(cherry picked from commit f944857)
felixfontein pushed a commit that referenced this pull request Jul 24, 2023
…if name is used without vmid (#7003)

* [proxmox_kvm] Don't create VM if name is used without vmid (#6981)

* [proxmox_kvm] Don't create VM if name is used without vmid

* Add changelog and unit tests

(cherry picked from commit f944857)

* Remove semantic markup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug module module plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proxmox_kvm: Create VM without providing vmid not idempotent
3 participants