cmd_runner module utils: fix bug when argument spec has implicit type #6968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
felixfontein
approved these changes
Jul 19, 2023
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #6977 🤖 @patchback |
|
@russoz thanks for fixing this! |
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6978 🤖 @patchback |
felixfontein
pushed a commit
that referenced
this pull request
Jul 20, 2023
…ug when argument spec has implicit type (#6977) cmd_runner module utils: fix bug when argument spec has implicit type (#6968) * cmd_runner module utils: fix bug when argument spec has implicit type * add changelog frag (cherry picked from commit f6714ed) Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
felixfontein
pushed a commit
that referenced
this pull request
Jul 20, 2023
…ug when argument spec has implicit type (#6978) cmd_runner module utils: fix bug when argument spec has implicit type (#6968) * cmd_runner module utils: fix bug when argument spec has implicit type * add changelog frag (cherry picked from commit f6714ed) Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When a parameter in
argument_spechas no type, meaning it is implicitly astr,CmdRunnerwould fail trying to find thetypekey in that dictionary.ISSUE TYPE
COMPONENT NAME
plugins/module_utils/cmd_runner.py