Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cobbler inventory plugin: Convert unicode to str #6923

Merged
merged 2 commits into from
Jul 16, 2023
Merged

cobbler inventory plugin: Convert unicode to str #6923

merged 2 commits into from
Jul 16, 2023

Conversation

Algirdas-Z
Copy link
Contributor

SUMMARY

Explicitly convert AnsibleUnicode to str() before passing it to xmlrpc client

Fixes #6922

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

community.general.cobbler

ADDITIONAL INFORMATION

@ansibullbot
Copy link
Collaborator

cc @opoplawski
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress bug This issue/PR relates to a bug inventory inventory plugin new_contributor Help guide this first time contributor plugins plugin (any type) labels Jul 13, 2023
@Algirdas-Z Algirdas-Z force-pushed the feat/cobbler_inventory branch from d036a31 to 37b20d6 Compare July 13, 2023 07:29
@Algirdas-Z Algirdas-Z marked this pull request as ready for review July 13, 2023 07:48
@ansibullbot ansibullbot removed the WIP Work in progress label Jul 13, 2023
felixfontein
felixfontein reviewed Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

plugins/inventory/cobbler.py Outdated Show resolved Hide resolved
changelogs/fragments/6923-cobbler-inventory_unicode.yml Outdated Show resolved Hide resolved
@felixfontein felixfontein changed the title plugins: Convert unicode to str cobbler inventory plugin: Convert unicode to str Jul 13, 2023
@Algirdas-Z Algirdas-Z requested a review from felixfontein July 13, 2023 19:38
felixfontein
felixfontein approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume you tested this and it works for you?

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Jul 13, 2023
@Algirdas-Z
Copy link
Contributor Author

LGTM. I assume you tested this and it works for you?

Yep, tested it on my setup, works fine ;)

@felixfontein
Copy link
Collaborator

If nobody objects, I'll merge this tomorrow.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jul 16, 2023
@felixfontein felixfontein merged commit 7020b27 into ansible-collections:main Jul 16, 2023
@patchback
Copy link

patchback bot commented Jul 16, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/7020b27b0a42b9fb253de7b4ad5257196ef2fab8/pr-6923

Backported as #6952

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@Algirdas-Z thanks for fixing this!

patchback bot pushed a commit that referenced this pull request Jul 16, 2023
@Algirdas-Z @patchback
cobbler inventory plugin: Convert unicode to str (#6923)
af9fd0e 
* plugins/inventory/cobbler: Convert unicode to str

* plugins/inventory/cobbler: Use text_type instead

(cherry picked from commit 7020b27)
@patchback patchback bot mentioned this pull request Jul 16, 2023
Merged
@patchback
Copy link

patchback bot commented Jul 16, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/7020b27b0a42b9fb253de7b4ad5257196ef2fab8/pr-6923

Backported as #6953

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 16, 2023
@Algirdas-Z @patchback
cobbler inventory plugin: Convert unicode to str (#6923)
7dd184a 
* plugins/inventory/cobbler: Convert unicode to str

* plugins/inventory/cobbler: Use text_type instead

(cherry picked from commit 7020b27)
@patchback patchback bot mentioned this pull request Jul 16, 2023
Merged
felixfontein pushed a commit that referenced this pull request Jul 16, 2023
@patchback @Algirdas-Z
[PR #6923/7020b27b backport][stable-6] cobbler inventory plugin: Conv…
b104c58 
…ert unicode to str (#6952)

cobbler inventory plugin: Convert unicode to str (#6923)

* plugins/inventory/cobbler: Convert unicode to str

* plugins/inventory/cobbler: Use text_type instead

(cherry picked from commit 7020b27)

Co-authored-by: Algirdas <76789112+Algirdas-Z@users.noreply.github.com>
felixfontein pushed a commit that referenced this pull request Jul 16, 2023
@patchback @Algirdas-Z
[PR #6923/7020b27b backport][stable-7] cobbler inventory plugin: Conv…
4816157 
…ert unicode to str (#6953)

cobbler inventory plugin: Convert unicode to str (#6923)

* plugins/inventory/cobbler: Convert unicode to str

* plugins/inventory/cobbler: Use text_type instead

(cherry picked from commit 7020b27)

Co-authored-by: Algirdas <76789112+Algirdas-Z@users.noreply.github.com>
valeriopoggi pushed a commit to valeriopoggi/community.general that referenced this pull request Jul 17, 2023
@Algirdas-Z @valeriopoggi
cobbler inventory plugin: Convert unicode to str (ansible-collections…
1d719c5 
…#6923)

* plugins/inventory/cobbler: Convert unicode to str

* plugins/inventory/cobbler: Use text_type instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug inventory inventory plugin new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cobbler inventory plugin auth
3 participants
@Algirdas-Z @ansibullbot @felixfontein