Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxmox: default value when checking for dict key #6838

Merged
merged 2 commits into from
Jul 7, 2023
Merged

proxmox: default value when checking for dict key #6838

merged 2 commits into from
Jul 7, 2023

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Jul 3, 2023

SUMMARY

Use dict.get() to return default value if template does not exist.

Fixes #5372

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

proxmox

@ansibullbot
Copy link
Collaborator

cc @Ajpantuso @Thulium-Drake @UnderGreen @joshainglis @karmab @tleguern
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module plugins plugin (any type) small_patch Hopefully easy to review labels Jul 3, 2023
@ansibullbot ansibullbot removed the small_patch Hopefully easy to review label Jul 3, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Jul 3, 2023
@russoz russoz requested a review from felixfontein July 7, 2023 06:05
felixfontein
felixfontein approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @UnderGreen what do you think?

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jul 7, 2023
@felixfontein felixfontein merged commit 49349fc into ansible-collections:main Jul 7, 2023
@patchback
Copy link

patchback bot commented Jul 7, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/49349fce5e421745615b9a502e3f63bdbbb5bc54/pr-6838

Backported as #6885

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@russoz @UnderGreen thanks!

patchback bot pushed a commit that referenced this pull request Jul 7, 2023
@russoz @patchback
proxmox: default value when checking for dict key (#6838)
6d10c2e 
* proxmox: default value when checking for dict key

* add changelog frag

(cherry picked from commit 49349fc)
@patchback patchback bot mentioned this pull request Jul 7, 2023
Merged
@patchback
Copy link

patchback bot commented Jul 7, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/49349fce5e421745615b9a502e3f63bdbbb5bc54/pr-6838

Backported as #6886

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 7, 2023
@russoz @patchback
proxmox: default value when checking for dict key (#6838)
fc88f6a 
* proxmox: default value when checking for dict key

* add changelog frag

(cherry picked from commit 49349fc)
@patchback patchback bot mentioned this pull request Jul 7, 2023
Merged
@russoz russoz deleted the 5372-exception branch July 7, 2023 21:43
felixfontein pushed a commit that referenced this pull request Jul 8, 2023
@patchback @russoz
[PR #6838/49349fce backport][stable-7] proxmox: default value when ch…
15cbc96 
…ecking for dict key (#6886)

proxmox: default value when checking for dict key (#6838)

* proxmox: default value when checking for dict key

* add changelog frag

(cherry picked from commit 49349fc)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
felixfontein pushed a commit that referenced this pull request Jul 8, 2023
@patchback @russoz
[PR #6838/49349fce backport][stable-6] proxmox: default value when ch…
7b71ffa 
…ecking for dict key (#6885)

proxmox: default value when checking for dict key (#6838)

* proxmox: default value when checking for dict key

* add changelog frag

(cherry picked from commit 49349fc)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UnderGreen UnderGreen UnderGreen approved these changes

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proxmox: Lack of error checking: "Cloning lxc VM 100 failed with exception: 'template'"
4 participants
@russoz @ansibullbot @felixfontein @UnderGreen