Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxmox_disk: fix failure to create cdrom #6770

Merged
merged 3 commits into from
Jun 26, 2023
Merged

proxmox_disk: fix failure to create cdrom #6770

merged 3 commits into from
Jun 26, 2023

Conversation

exodious
Copy link
Contributor

@exodious exodious commented Jun 23, 2023 •
edited
Loading

SUMMARY

proxmox_disk was always specifying the size when formatting the configuration string, which doesn't work when the media param is cdrom.

Fixes #6765.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

proxmox_disk

ADDITIONAL INFORMATION

@ansibullbot
Copy link
Collaborator

cc @Ajpantuso @Thulium-Drake @UnderGreen @castorsky @joshainglis @karmab @tleguern
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Jun 23, 2023
@ansibullbot ansibullbot removed the small_patch Hopefully easy to review label Jun 23, 2023
@exodious exodious marked this pull request as ready for review June 23, 2023 00:58
@ansibullbot ansibullbot removed the WIP Work in progress label Jun 23, 2023
@exodious
Copy link
Contributor Author

@castorsky I'd be happy to add an integration test specifically for this, but I don't fully understand how the tests are set up. It wouldn't be sufficient to test this only with disk types like scsi, virtio, etc. since this is generally ide2 with storage set to an ISO, and media must be cdrom.

@castorsky
Copy link
Contributor

@castorsky It wouldn't be sufficient to test this only with disk types like scsi, virtio, etc. since this is generally ide2 with storage set to an ISO, and media must be cdrom.

It is impossiblle to predict all combinations of parameters and all possible situations. :) No need to include them all to tests.
You did a great work by diggin into the problem. Thank you! 👍

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Jun 24, 2023
@exodious @felixfontein
Update changelogs/fragments/6770-proxmox_disk_create_cdrom.yml
893aded 
Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein
felixfontein reviewed Jun 25, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If nobody objects I'll merge this at the beginning of the upcoming week.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jun 26, 2023
@felixfontein felixfontein merged commit 70e2048 into ansible-collections:main Jun 26, 2023
@patchback
Copy link

patchback bot commented Jun 26, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/70e2048d8c38c3df8f029b6adcde4fe8551f415d/pr-6770

Backported as #6795

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 26, 2023
@exodious @patchback
proxmox_disk: fix failure to create cdrom (#6770)
ace0527 
* proxmox_disk: fix failure to create cdrom

* Add changelog fragment 6770

* Update changelogs/fragments/6770-proxmox_disk_create_cdrom.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 70e2048)
@patchback patchback bot mentioned this pull request Jun 26, 2023
Merged
@patchback
Copy link

patchback bot commented Jun 26, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/70e2048d8c38c3df8f029b6adcde4fe8551f415d/pr-6770

Backported as #6796

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@exodious thanks for your contribution!
@castorsky thanks for reviewing!

patchback bot pushed a commit that referenced this pull request Jun 26, 2023
@exodious @patchback
proxmox_disk: fix failure to create cdrom (#6770)
f7dae42 
* proxmox_disk: fix failure to create cdrom

* Add changelog fragment 6770

* Update changelogs/fragments/6770-proxmox_disk_create_cdrom.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 70e2048)
@patchback patchback bot mentioned this pull request Jun 26, 2023
Merged
felixfontein pushed a commit that referenced this pull request Jun 27, 2023
@patchback @exodious
[PR #6770/70e2048d backport][stable-6] proxmox_disk: fix failure to c…
a9a9e72 
…reate cdrom (#6795)

proxmox_disk: fix failure to create cdrom (#6770)

* proxmox_disk: fix failure to create cdrom

* Add changelog fragment 6770

* Update changelogs/fragments/6770-proxmox_disk_create_cdrom.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 70e2048)

Co-authored-by: exodious <10215736+exodious@users.noreply.github.com>
felixfontein pushed a commit that referenced this pull request Jun 27, 2023
@patchback @exodious
[PR #6770/70e2048d backport][stable-7] proxmox_disk: fix failure to c…
dc898df 
…reate cdrom (#6796)

proxmox_disk: fix failure to create cdrom (#6770)

* proxmox_disk: fix failure to create cdrom

* Add changelog fragment 6770

* Update changelogs/fragments/6770-proxmox_disk_create_cdrom.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 70e2048)

Co-authored-by: exodious <10215736+exodious@users.noreply.github.com>
@exodious exodious deleted the fix_proxmox_disk_cdrom branch July 2, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proxmox disk fails to create cdrom
4 participants
@exodious @ansibullbot @castorsky @felixfontein