Fixing bug in get_volume_inventory #6719

TSKushal · 2023-06-17T17:32:15Z

SUMMARY
Fixing issues found in GetVolumeInventory. The issues are as below:

Controller name can be found directly under each member of the storage API -> /redfish/v1/Systems/1/Storage//. With the existing code the controller is not being populated as expected.
The volumes collected are repeated in the subsequent controllers i.e., if Controller 1 has 2 volumes, the same 2 volumes are also displayed under Controller 2 along with any volumes in Controller 2.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
redfish_utils.py

ADDITIONAL INFORMATION
Sample .yaml used

---
- hosts: localhost
  tasks:
    - name: Get Volume Inventory
      community.general.redfish_info:
        category: Systems
        command: GetVolumeInventory
        baseuri: "10.131.0.209"
        username: "admin"
        password: "HP1nvent"
      register: result

    - name: Print fetched information
      ansible.builtin.debug:
        msg: "{{ result.redfish_facts.volume.entries }}"

Output before suggested code change:

TASK [Print fetched information] ***********************************************
ok: [localhost] => {
    "msg": [
        [
            {
                "system_uri": "/redfish/v1/Systems/1/"
            },
            [
                {
                    "Controller": "Controller 1",
                    "Volumes": [
                        {
                            "BlockSizeBytes": 512,
                            "CapacityBytes": 1599774654464,
                            "Encrypted": false,
                            "EncryptionTypes": [],
                            "Id": "238",
                            "Identifiers": [
                                {
                                    "DurableName": "600062B2127C60802C1FC5D485606669",
                                    "DurableNameFormat": "NAA"
                                }
                            ],
                            "Linked_drives": [
                                {
                                    "Id": "1"
                                }
                            ],
                            "Name": "MR Volume1",
                            "Operations": [],
                            "OptimumIOSizeBytes": 65536,
                            "RAIDType": "RAID0",
                            "Status": {
                                "Health": "OK",
                                "State": "Enabled"
                            }
                        },
                        {
                            "BlockSizeBytes": 512,
                            "CapacityBytes": 1599774654464,
                            "Encrypted": false,
                            "EncryptionTypes": [],
                            "Id": "239",
                            "Identifiers": [
                                {
                                    "DurableName": "600062B2127C60802C1FB98B3772214B",
                                    "DurableNameFormat": "NAA"
                                }
                            ],
                            "Linked_drives": [
                                {
                                    "Id": "0"
                                }
                            ],
                            "Name": "MR Volume2",
                            "Operations": [],
                            "OptimumIOSizeBytes": 65536,
                            "RAIDType": "RAID0",
                            "Status": {
                                "Health": "OK",
                                "State": "Enabled"
                            }
                        }
                    ]
                },
                {
                    "Controller": "Controller 1",
                    "Volumes": [
                        {
                            "BlockSizeBytes": 512,
                            "CapacityBytes": 1599774654464,
                            "Encrypted": false,
                            "EncryptionTypes": [],
                            "Id": "238",
                            "Identifiers": [
                                {
                                    "DurableName": "600062B2127C60802C1FC5D485606669",
                                    "DurableNameFormat": "NAA"
                                }
                            ],
                            "Linked_drives": [
                                {
                                    "Id": "1"
                                }
                            ],
                            "Name": "MR Volume1",
                            "Operations": [],
                            "OptimumIOSizeBytes": 65536,
                            "RAIDType": "RAID0",
                            "Status": {
                                "Health": "OK",
                                "State": "Enabled"
                            }
                        },
                        {
                            "BlockSizeBytes": 512,
                            "CapacityBytes": 1599774654464,
                            "Encrypted": false,
                            "EncryptionTypes": [],
                            "Id": "239",
                            "Identifiers": [
                                {
                                    "DurableName": "600062B2127C60802C1FB98B3772214B",
                                    "DurableNameFormat": "NAA"
                                }
                            ],
                            "Linked_drives": [
                                {
                                    "Id": "0"
                                }
                            ],
                            "Name": "MR Volume2",
                            "Operations": [],
                            "OptimumIOSizeBytes": 65536,
                            "RAIDType": "RAID0",
                            "Status": {
                                "Health": "OK",
                                "State": "Enabled"
                            }
                        },
                        {
                            "BlockSizeBytes": 512,
                            "CapacityBytes": 480036519936,
                            "Encrypted": false,
                            "Id": "1",
                            "Identifiers": [
                                {
                                    "DurableName": "005043e105000001",
                                    "DurableNameFormat": "EUI"
                                }
                            ],
                            "Linked_drives": [
                                {
                                    "Id": "1"
                                },
                                {
                                    "Id": "2"
                                }
                            ],
                            "Name": "NS Volume",
                            "Operations": [],
                            "OptimumIOSizeBytes": 131072,
                            "RAIDType": "RAID1",
                            "Status": {
                                "Health": "OK",
                                "State": "Enabled"
                            }
                        }
                    ]
                }
            ]
        ]
    ]
}

Output after suggested code change:

TASK [Print fetched information] ***********************************************
ok: [localhost] => {
    "msg": [
        [
            {
                "system_uri": "/redfish/v1/Systems/1/"
            },
            [
                {
                    "Controller": "HPE MR416i-o Gen11",
                    "Volumes": [
                        {
                            "BlockSizeBytes": 512,
                            "CapacityBytes": 1599774654464,
                            "Encrypted": false,
                            "EncryptionTypes": [],
                            "Id": "238",
                            "Identifiers": [
                                {
                                    "DurableName": "600062B2127C60802C1FC5D485606669",
                                    "DurableNameFormat": "NAA"
                                }
                            ],
                            "Linked_drives": [
                                {
                                    "Id": "1"
                                }
                            ],
                            "Name": "MR Volume1",
                            "Operations": [],
                            "OptimumIOSizeBytes": 65536,
                            "RAIDType": "RAID0",
                            "Status": {
                                "Health": "OK",
                                "State": "Enabled"
                            }
                        },
                        {
                            "BlockSizeBytes": 512,
                            "CapacityBytes": 1599774654464,
                            "Encrypted": false,
                            "EncryptionTypes": [],
                            "Id": "239",
                            "Identifiers": [
                                {
                                    "DurableName": "600062B2127C60802C1FB98B3772214B",
                                    "DurableNameFormat": "NAA"
                                }
                            ],
                            "Linked_drives": [
                                {
                                    "Id": "0"
                                }
                            ],
                            "Name": "MR Volume2",
                            "Operations": [],
                            "OptimumIOSizeBytes": 65536,
                            "RAIDType": "RAID0",
                            "Status": {
                                "Health": "OK",
                                "State": "Enabled"
                            }
                        }
                    ]
                },
                {
                    "Controller": "HPE NS204i-p Gen10+ Boot Controller",
                    "Volumes": [
                        {
                            "BlockSizeBytes": 512,
                            "CapacityBytes": 480036519936,
                            "Encrypted": false,
                            "Id": "1",
                            "Identifiers": [
                                {
                                    "DurableName": "005043e105000001",
                                    "DurableNameFormat": "EUI"
                                }
                            ],
                            "Linked_drives": [
                                {
                                    "Id": "1"
                                },
                                {
                                    "Id": "2"
                                }
                            ],
                            "Name": "NS Volume",
                            "Operations": [],
                            "OptimumIOSizeBytes": 131072,
                            "RAIDType": "RAID1",
                            "Status": {
                                "Health": "OK",
                                "State": "Enabled"
                            }
                        }
                    ]
                }
            ]
        ]
    ]
}

ansibullbot · 2023-06-17T17:35:20Z

cc @Bhavya06 @jyundt @mraineri @rajeevkallur @renxulei @tomasg2012 @xmadsen
click here for bot help

felixfontein

Thanks for your contribution. I've added a first comment.

changelogs/fragments/6719-redfish-utils-fix-for-get-volume-inventory.yml

…entory.yml Agreed Co-authored-by: Felix Fontein <felix@fontein.de>

changelogs/fragments/6719-redfish-utils-fix-for-get-volume-inventory.yml

…entory.yml Agreed Co-authored-by: Felix Fontein <felix@fontein.de>

mraineri · 2023-06-19T12:56:22Z

plugins/module_utils/redfish_utils.py

-                            else:
-                                sc_id = sc[0].get('Id', '1')
-                                controller_name = 'Controller %s' % sc_id
+                    if 'Name' in data:


This logic isn't correct; this pulls the name of the storage subsystem rather than of the storage controller.

Inside the Storage resource is a "StorageControllers" property; this property contains the set of storage controllers in the storage subsystem, which is what this controller_list is intended to contain.

Actually this is under a for loop which is iterating through each controller.

for controller in data[u'Members']: controller_list.append(controller[u'@odata.id']) for c in controller_list: uri = self.root_uri + c response = self.get_request(uri) if response['ret'] is False: return response data = response['data'] controller_name = 'Controller 1' if 'StorageControllers' in data: sc = data['StorageControllers'] if sc: if 'Name' in sc[0]: controller_name = sc[0]['Name'] else: sc_id = sc[0].get('Id', '1') controller_name = 'Controller %s' % sc_id if 'Name' in data:

mraineri · 2023-06-19T12:57:37Z

@TSKushal can you please show what's inside of your Storage resources? Reviewing the logic in place today I believe the behavior is correct and the issue lies with the Redfish service not providing proper names for storage controllers.

mraineri · 2023-06-19T13:00:03Z

Controller name can be found directly under each member of the storage API -> /redfish/v1/Systems/1/Storage//. With the existing code the controller is not being populated as expected.

This statement is not correct; the name at that level per the spec is for the Storage resource and not the individual controller (or controllers) inside that storage subsystem. Clients need to step into the controllers array to extract the name information for the controllers.

TSKushal · 2023-06-19T13:05:03Z

Controller name can be found directly under each member of the storage API -> /redfish/v1/Systems/1/Storage//. With the existing code the controller is not being populated as expected.

This statement is not correct; the name at that level per the spec is for the Storage resource and not the individual controller (or controllers) inside that storage subsystem. Clients need to step into the controllers array to extract the name information for the controllers.

Correct, I didn't mean at /redfish/v1/Systems/1/Storage/ level.
Each member under "/redfish/v1/Systems/1/Storage/" is what i was referring to i.e., /redfish/v1/Systems/1/Storage/

TSKushal · 2023-06-19T13:07:48Z

Redfish responses

/redfish/v1/Systems/1/Storage/

{
    "@odata.context": "/redfish/v1/$metadata#StorageCollection.StorageCollection",
    "@odata.etag": "W/\"570254F2\"",
    "@odata.id": "/redfish/v1/Systems/1/Storage/",
    "@odata.type": "#StorageCollection.StorageCollection",
    "Description": "Storage subsystems known to this system",
    "Name": "Storage",
    "Members": [
        {
            "@odata.id": "/redfish/v1/Systems/1/Storage/DE00B000/"
        },
        {
            "@odata.id": "/redfish/v1/Systems/1/Storage/DE00A000/"
        }
    ],
    "Members@odata.count": 2
}

/redfish/v1/Systems/1/Storage/DE00B000/

{
    "@odata.etag": "\"a9279128\"",
    "@odata.id": "/redfish/v1/Systems/1/Storage/DE00B000",
    "@odata.type": "#Storage.v1_11_0.Storage",
    "Id": "DE00B000",
    "Name": "HPE MR416i-o Gen11",
    "Actions": {
        "#Storage.ResetToDefaults": {
            "ResetType@Redfish.AllowableValues": [
                "ResetAll",
                "PreserveVolumes"
            ],
            "target": "/redfish/v1/Systems/1/Storage/DE00B000/Actions/Storage.ResetToDefaults"
        }
    },
    "Status": {
        "State": "Enabled",
        "HealthRollup": "OK"
    },
    "Drives@odata.count": 2,
    "Drives": [
        {
            "@odata.id": "/redfish/v1/Systems/1/Storage/DE00B000/Drives/0"
        },
        {
            "@odata.id": "/redfish/v1/Systems/1/Storage/DE00B000/Drives/1"
        }
    ],
    "Volumes": {
        "@odata.id": "/redfish/v1/Systems/1/Storage/DE00B000/Volumes"
    },
    "Controllers": {
        "@odata.id": "/redfish/v1/Systems/1/Storage/DE00B000/Controllers"
    }
}

/redfish/v1/Systems/1/Storage/DE00A000/

{
    "@odata.etag": "W/\"298afb7b\"",
    "@odata.id": "/redfish/v1/Systems/1/Storage/DE00A000",
    "@odata.type": "#Storage.v1_7_1.Storage",
    "Id": "DE00A000",
    "Name": "HPE NS204i-p Gen10+ Boot Controller",
    "Status": {
        "State": "Enabled",
        "HealthRollup": "OK"
    },
    "Drives@odata.count": 2,
    "Drives": [
        {
            "@odata.id": "/redfish/v1/Systems/1/Storage/DE00A000/Drives/1"
        },
        {
            "@odata.id": "/redfish/v1/Systems/1/Storage/DE00A000/Drives/2"
        }
    ],
    "Volumes": {
        "@odata.id": "/redfish/v1/Systems/1/Storage/DE00A000/Volumes"
    },
    "StorageControllers": [
        {
            "@odata.id": "/redfish/v1/Systems/1/Storage/DE00A000#/StorageControllers/0",
            "CacheSummary": {
                "TotalCacheSizeMiB": 0,
                "PersistentCacheSizeMiB": 0,
                "Status": {
                    "Health": "OK",
                    "State": "Absent"
                }
            },
            "ControllerRates": {
                "ConsistencyCheckRatePercent": 100,
                "RebuildRatePercent": 100
            },
            "FirmwareVersion": "1.2.14.1004",
            "Identifiers": [
                {
                    "DurableName": "53:48:00:d0:00:f3:35:3a",
                    "DurableNameFormat": "NAA"
                }
            ],
            "Location": {
                "PartLocation": {
                    "ServiceLabel": "Slot 1",
                    "LocationType": "Slot",
                    "LocationOrdinalValue": 1
                }
            },
            "Manufacturer": "HPE",
            "MemberId": "0",
            "Model": "HPE NS204i-p Gen10+ Boot Controller",
            "PartNumber": "P14379-001",
            "PCIeInterface": {
                "MaxPCIeType": "Gen3",
                "PCIeType": "Gen3",
                "MaxLanes": 4,
                "LanesInUse": 4
            },
            "SKU": "P12965-B21",
            "SerialNumber": "PWWVF0DSTGW0EZ",
            "Status": {
                "State": "Enabled",
                "Health": "OK"
            },
            "SupportedControllerProtocols": [
                "PCIe"
            ],
            "SupportedDeviceProtocols": [
                "NVMe"
            ],
            "SupportedRAIDTypes": [
                "RAID1"
            ]
        }
    ]
}

mraineri · 2023-06-19T13:13:56Z

For /redfish/v1/Systems/1/Storage/DE00A000/, the StorageControllers array does not contain names of the storage controllers. It just contains "MemberId", but no "Name" property, which is why the logic is entering the default naming case.

For /redfish/v1/Systems/1/Storage/DE00B000/, that storage resource instead contains a "Controllers" resource collection rather than "StorageControllers". This is valid, and I would propose we should modify the logic to step into "Controllers" and extract the controller names via their dedicated resources if this is present.

TSKushal · 2023-06-19T13:21:59Z

For /redfish/v1/Systems/1/Storage/DE00A000/, the StorageControllers array does not contain names of the storage controllers. It just contains "MemberId", but no "Name" property, which is why the logic is entering the default naming case.

For /redfish/v1/Systems/1/Storage/DE00B000/, that storage resource instead contains a "Controllers" resource collection rather than "StorageControllers". This is valid, and I would propose we should modify the logic to step into "Controllers" and extract the controller names via their dedicated resources if this is present.

This was going to be my initial change, but then I observed that "/redfish/v1/Systems/1/Storage/DE00A000#/StorageControllers/0" contains the same name,

{
    "@odata.etag": "W/\"298afb7b\"",
    "@odata.id": "/redfish/v1/Systems/1/Storage/DE00A000",
    "@odata.type": "#Storage.v1_7_1.Storage",
    "Id": "DE00A000",
    "Name": "HPE NS204i-p Gen10+ Boot Controller",
    "Status": {
        "State": "Enabled",
        "HealthRollup": "OK"
    },
    "Drives@odata.count": 2,
    "Drives": [
        {
            "@odata.id": "/redfish/v1/Systems/1/Storage/DE00A000/Drives/1"
        },
        {
            "@odata.id": "/redfish/v1/Systems/1/Storage/DE00A000/Drives/2"
        }
    ],
    "Volumes": {
        "@odata.id": "/redfish/v1/Systems/1/Storage/DE00A000/Volumes"
    },
    "StorageControllers": [
        {
            "@odata.id": "/redfish/v1/Systems/1/Storage/DE00A000#/StorageControllers/0",
            "CacheSummary": {
                "TotalCacheSizeMiB": 0,
                "PersistentCacheSizeMiB": 0,
                "Status": {
                    "Health": "OK",
                    "State": "Absent"
                }
            },
            "ControllerRates": {
                "ConsistencyCheckRatePercent": 100,
                "RebuildRatePercent": 100
            },
            "FirmwareVersion": "1.2.14.1004",
            "Identifiers": [
                {
                    "DurableName": "53:48:00:d0:00:f3:35:3a",
                    "DurableNameFormat": "NAA"
                }
            ],
            "Location": {
                "PartLocation": {
                    "ServiceLabel": "Slot 1",
                    "LocationType": "Slot",
                    "LocationOrdinalValue": 1
                }
            },
            "Manufacturer": "HPE",
            "MemberId": "0",
            "Model": "HPE NS204i-p Gen10+ Boot Controller",
            "PartNumber": "P14379-001",
            "PCIeInterface": {
                "MaxPCIeType": "Gen3",
                "PCIeType": "Gen3",
                "MaxLanes": 4,
                "LanesInUse": 4
            },
            "SKU": "P12965-B21",
            "SerialNumber": "PWWVF0DSTGW0EZ",
            "Status": {
                "State": "Enabled",
                "Health": "OK"
            },
            "SupportedControllerProtocols": [
                "PCIe"
            ],
            "SupportedDeviceProtocols": [
                "NVMe"
            ],
            "SupportedRAIDTypes": [
                "RAID1"
            ]
        }
    ]
}

Is there any case where the Name directly under "/redfish/v1/Systems/1/Storage/DE00A000" and "/redfish/v1/Systems/1/Storage/DE00A000#/StorageControllers/0" will not be same?

mraineri · 2023-06-19T14:33:26Z

I would never expect them to be the same; "Name" inside of "/redfish/v1/Systems/1/Storage/DE00A000" (or any Storage resource) is the name of the storage subsystem; this is independent of the controller name.

TSKushal · 2023-06-19T15:29:24Z

I would never expect them to be the same; "Name" inside of "/redfish/v1/Systems/1/Storage/DE00A000" (or any Storage resource) is the name of the storage subsystem; this is independent of the controller name.

Ah alright, I think I got confused with the subsystem name and the actual controller name. Will make the changes as suggested.

TSKushal · 2023-06-26T10:44:24Z

@mraineri any updates on this?

mraineri · 2023-06-26T12:33:23Z

plugins/module_utils/redfish_utils.py

@@ -912,7 +912,26 @@ def get_volume_inventory(self, systems_uri):
                            else:
                                sc_id = sc[0].get('Id', '1')
                                controller_name = 'Controller %s' % sc_id
+                    if 'Controllers' in data:


I would make this an elif; if StorageControllers was found, there's no need to step into Controllers. Both will represent the same storage controllers in the storage subsystem. It's possible for a service to implement both in order to support clients that expect the older method (StorageControllers) and to support clients that expect the newer method (Controllers).

I see your point. Changing as suggested.

mraineri · 2023-06-26T18:17:23Z

shipit

patchback · 2023-06-26T21:29:21Z

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/22efbcc627764f29ce1e75f634dacab8566d2299/pr-6719

Backported as #6791

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

* Fixing bug in get_volume_inventory * Adding changelog fragment * sanity fix * Update changelogs/fragments/6719-redfish-utils-fix-for-get-volume-inventory.yml Agreed Co-authored-by: Felix Fontein <felix@fontein.de> * Updating changelog fragment * Update changelogs/fragments/6719-redfish-utils-fix-for-get-volume-inventory.yml Agreed Co-authored-by: Felix Fontein <felix@fontein.de> * Updating changes as per PR comments * PR comment changes --------- Co-authored-by: Kushal <t-s.kushal@hpe.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 22efbcc)

patchback · 2023-06-26T21:29:31Z

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/22efbcc627764f29ce1e75f634dacab8566d2299/pr-6719

Backported as #6792

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

* Fixing bug in get_volume_inventory * Adding changelog fragment * sanity fix * Update changelogs/fragments/6719-redfish-utils-fix-for-get-volume-inventory.yml Agreed Co-authored-by: Felix Fontein <felix@fontein.de> * Updating changelog fragment * Update changelogs/fragments/6719-redfish-utils-fix-for-get-volume-inventory.yml Agreed Co-authored-by: Felix Fontein <felix@fontein.de> * Updating changes as per PR comments * PR comment changes --------- Co-authored-by: Kushal <t-s.kushal@hpe.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 22efbcc)

felixfontein · 2023-06-26T21:29:42Z

@TSKushal thanks for your contribution!
@mraineri thanks for reviewing!

…tory (#6792) Fixing bug in get_volume_inventory (#6719) * Fixing bug in get_volume_inventory * Adding changelog fragment * sanity fix * Update changelogs/fragments/6719-redfish-utils-fix-for-get-volume-inventory.yml Agreed Co-authored-by: Felix Fontein <felix@fontein.de> * Updating changelog fragment * Update changelogs/fragments/6719-redfish-utils-fix-for-get-volume-inventory.yml Agreed Co-authored-by: Felix Fontein <felix@fontein.de> * Updating changes as per PR comments * PR comment changes --------- Co-authored-by: Kushal <t-s.kushal@hpe.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 22efbcc) Co-authored-by: TSKushal <44438079+TSKushal@users.noreply.github.com>

…tory (#6791) Fixing bug in get_volume_inventory (#6719) * Fixing bug in get_volume_inventory * Adding changelog fragment * sanity fix * Update changelogs/fragments/6719-redfish-utils-fix-for-get-volume-inventory.yml Agreed Co-authored-by: Felix Fontein <felix@fontein.de> * Updating changelog fragment * Update changelogs/fragments/6719-redfish-utils-fix-for-get-volume-inventory.yml Agreed Co-authored-by: Felix Fontein <felix@fontein.de> * Updating changes as per PR comments * PR comment changes --------- Co-authored-by: Kushal <t-s.kushal@hpe.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 22efbcc) Co-authored-by: TSKushal <44438079+TSKushal@users.noreply.github.com>

Fixing bug in get_volume_inventory

65e61d4

ansibullbot added bug This issue/PR relates to a bug module_utils module_utils plugins plugin (any type) labels Jun 17, 2023

Adding changelog fragment

c127690

This comment was marked as outdated.

Sign in to view

ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jun 17, 2023

sanity fix

8782f0c

ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jun 17, 2023

felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Jun 18, 2023

felixfontein reviewed Jun 18, 2023

View reviewed changes

changelogs/fragments/6719-redfish-utils-fix-for-get-volume-inventory.yml Outdated Show resolved Hide resolved

TSKushal and others added 2 commits June 19, 2023 12:43

Update changelogs/fragments/6719-redfish-utils-fix-for-get-volume-inv…

1ea7182

…entory.yml Agreed Co-authored-by: Felix Fontein <felix@fontein.de>

Updating changelog fragment

3016c00

felixfontein reviewed Jun 19, 2023

View reviewed changes

changelogs/fragments/6719-redfish-utils-fix-for-get-volume-inventory.yml Outdated Show resolved Hide resolved

Update changelogs/fragments/6719-redfish-utils-fix-for-get-volume-inv…

c495c6c

…entory.yml Agreed Co-authored-by: Felix Fontein <felix@fontein.de>

mraineri reviewed Jun 19, 2023

View reviewed changes

Updating changes as per PR comments

ecb4b9e

mraineri reviewed Jun 26, 2023

View reviewed changes

PR comment changes

56c268f

felixfontein merged commit 22efbcc into ansible-collections:main Jun 26, 2023

felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jun 26, 2023

patchback bot mentioned this pull request Jun 26, 2023

[PR #6719/22efbcc6 backport][stable-6] Fixing bug in get_volume_inventory #6791

Merged

patchback bot mentioned this pull request Jun 26, 2023

[PR #6719/22efbcc6 backport][stable-7] Fixing bug in get_volume_inventory #6792

Merged

TSKushal deleted the update_get_volume_inventory branch June 29, 2023 16:05

TSKushal mentioned this pull request Jul 7, 2023

Fix for get_volume_inventory #6883

Merged

This was referenced Jul 15, 2023

[PR #6883/c70edfa8 backport][stable-6] Fix for get_volume_inventory #6947

Merged

[PR #6883/c70edfa8 backport][stable-7] Fix for get_volume_inventory #6948

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing bug in get_volume_inventory #6719

Fixing bug in get_volume_inventory #6719

TSKushal commented Jun 17, 2023 •

edited

Loading

ansibullbot commented Jun 17, 2023

This comment was marked as outdated.

felixfontein left a comment

mraineri Jun 19, 2023

TSKushal Jun 19, 2023

mraineri commented Jun 19, 2023

mraineri commented Jun 19, 2023

TSKushal commented Jun 19, 2023

TSKushal commented Jun 19, 2023

mraineri commented Jun 19, 2023 •

edited

Loading

TSKushal commented Jun 19, 2023

mraineri commented Jun 19, 2023

TSKushal commented Jun 19, 2023

TSKushal commented Jun 26, 2023

mraineri Jun 26, 2023 •

edited

Loading

TSKushal Jun 26, 2023

mraineri commented Jun 26, 2023

patchback bot commented Jun 26, 2023 •

edited

Loading

patchback bot commented Jun 26, 2023 •

edited

Loading

felixfontein commented Jun 26, 2023

Fixing bug in get_volume_inventory #6719

Fixing bug in get_volume_inventory #6719

Conversation

TSKushal commented Jun 17, 2023 • edited Loading

ansibullbot commented Jun 17, 2023

This comment was marked as outdated.

felixfontein left a comment

Choose a reason for hiding this comment

mraineri Jun 19, 2023

Choose a reason for hiding this comment

TSKushal Jun 19, 2023

Choose a reason for hiding this comment

mraineri commented Jun 19, 2023

mraineri commented Jun 19, 2023

TSKushal commented Jun 19, 2023

TSKushal commented Jun 19, 2023

mraineri commented Jun 19, 2023 • edited Loading

TSKushal commented Jun 19, 2023

mraineri commented Jun 19, 2023

TSKushal commented Jun 19, 2023

TSKushal commented Jun 26, 2023

mraineri Jun 26, 2023 • edited Loading

Choose a reason for hiding this comment

TSKushal Jun 26, 2023

Choose a reason for hiding this comment

mraineri commented Jun 26, 2023

patchback bot commented Jun 26, 2023 • edited Loading

Backport to stable-6: 💚 backport PR created

patchback bot commented Jun 26, 2023 • edited Loading

Backport to stable-7: 💚 backport PR created

felixfontein commented Jun 26, 2023

TSKushal commented Jun 17, 2023 •

edited

Loading

mraineri commented Jun 19, 2023 •

edited

Loading

mraineri Jun 26, 2023 •

edited

Loading

patchback bot commented Jun 26, 2023 •

edited

Loading

patchback bot commented Jun 26, 2023 •

edited

Loading