Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6688/032996e0 backport][stable-7] Fix composites comparison for role in is_struct_included keycloak.py … #6690

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jun 14, 2023

This is a backport of PR #6688 as merged into main (032996e).

Fix comparison problem with is_struct_included function of keycloak.py module utils.

SUMMARY

This apply when we compare composite in keycloak roles to detect if a change is needed.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

keycloak.py module utils

ADDITIONAL INFORMATION

This fis is needed to support composites in Keycloak roles.

#6688)

* Fix composites comparison for role in is_struct_included keycloak.py function

* Add changelog fragment and unit tests

* Update changelogs/fragments/6688-is-struct-included-bug-in-keycloak-py.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 032996e)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug identity module_utils module_utils new_contributor Help guide this first time contributor plugins plugin (any type) tests tests unit tests/unit labels Jun 14, 2023
@felixfontein felixfontein merged commit a8f5926 into stable-7 Jun 14, 2023
@felixfontein felixfontein deleted the patchback/backports/stable-7/032996e0052a514a17775c4492532c3505a7e142/pr-6688 branch June 14, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug identity module_utils module_utils new_contributor Help guide this first time contributor plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants