rhsm_repository: update returned "repositories" when using "purge=true" #6676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the "purge" option was enabled, the "repositories" element in the returned JSON was not updated with the repositories disabled by that option.
ansibullbot
added
bug
ptoscano
force-pushed
the
rhsm_repository-fix-returned-repositories-with-purge
branch
from
67ebd18 to
a773458
Compare
felixfontein
added
check-before-release
|
The change looks formally OK, but I have no idea whether it is correct. If you want to wait for someone to review it that's fine, but if you want it merged just tell me. |
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #6745 🤖 @patchback |
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6746 🤖 @patchback |
|
@ptoscano thanks for your contribution! |
felixfontein
removed
the
check-before-release
felixfontein
pushed a commit
that referenced
this pull request
Jun 20, 2023
…ed "repositories" when using "purge=true" (#6745) rhsm_repository: update returned "repositories" when using "purge=true" (#6676) In case the "purge" option was enabled, the "repositories" element in the returned JSON was not updated with the repositories disabled by that option. (cherry picked from commit ffb9b6f) Co-authored-by: Pino Toscano <ptoscano@redhat.com>
felixfontein
pushed a commit
that referenced
this pull request
Jun 20, 2023
…ed "repositories" when using "purge=true" (#6746) rhsm_repository: update returned "repositories" when using "purge=true" (#6676) In case the "purge" option was enabled, the "repositories" element in the returned JSON was not updated with the repositories disabled by that option. (cherry picked from commit ffb9b6f) Co-authored-by: Pino Toscano <ptoscano@redhat.com>
ptoscano
deleted the
rhsm_repository-fix-returned-repositories-with-purge
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In case the
purgeoption was enabled, therepositorieselement in the returned JSON was not updated with the repositories disabled by that option.ISSUE TYPE
COMPONENT NAME
rhsm_repository