Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

puppet: fix noop parameter error #6458

Merged
merged 2 commits into from
May 3, 2023
Merged

puppet: fix noop parameter error #6458

merged 2 commits into from
May 3, 2023

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Apr 29, 2023

SUMMARY

Simplified the handling of the noop parameter, solving the reported error.

Also revamped the unit test a bit, adding two test cases to prove the fix.

Fixes #6452

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

puppet

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module_utils module_utils plugins plugin (any type) tests tests unit tests/unit labels Apr 29, 2023
@russoz russoz requested a review from felixfontein April 30, 2023 00:54
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Apr 30, 2023
felixfontein
felixfontein approved these changes Apr 30, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand the change it looks good.

@felixfontein felixfontein merged commit d254372 into ansible-collections:main May 3, 2023
@patchback
Copy link

patchback bot commented May 3, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/d254372d376b428ab939351cc4319028b12000d4/pr-6458

Backported as #6481

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label May 3, 2023
@felixfontein
Copy link
Collaborator

@russoz thanks!

patchback bot pushed a commit that referenced this pull request May 3, 2023
@russoz @patchback
puppet: fix noop parameter error (#6458)
5b6beec 
* puppet: fix noop parameter error

* add changelog frag

(cherry picked from commit d254372)
@patchback patchback bot mentioned this pull request May 3, 2023
Merged
@russoz russoz deleted the 6452-puppet-noop.yml branch May 3, 2023 20:45
felixfontein pushed a commit that referenced this pull request May 4, 2023
@patchback @russoz
[PR #6458/d254372d backport][stable-6] puppet: fix noop parameter err…
3a19fbc 
…or (#6481)

puppet: fix noop parameter error (#6458)

* puppet: fix noop parameter error

* add changelog frag

(cherry picked from commit d254372)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug module_utils module_utils plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

puppet module - noop parameter with boolean value fails with "parameter takes exactly 3 arguments (2 given)"
3 participants
@russoz @felixfontein @ansibullbot