Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

passwordstore plugin: vendor FileLock that was removed from ansible-core devel #6447

Merged
merged 1 commit into from
Apr 28, 2023
Merged

passwordstore plugin: vendor FileLock that was removed from ansible-core devel #6447

merged 1 commit into from
Apr 28, 2023

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

ansible/ansible#80438 removed functionality that the passwordstore plugin was still using.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

passwordstore lookup

@felixfontein felixfontein requested a review from russoz April 28, 2023 08:47
@ansibullbot ansibullbot added bug This issue/PR relates to a bug lookup lookup plugin module_utils module_utils plugins plugin (any type) labels Apr 28, 2023
russoz
russoz approved these changes Apr 28, 2023
View reviewed changes
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit c58dda1 into ansible-collections:main Apr 28, 2023
@patchback
Copy link

patchback bot commented Apr 28, 2023 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/c58dda14c203c3f60e093ccc6c18d4e0f2687a7e/pr-6447

Backported as #6449

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the filelock branch April 28, 2023 10:08
patchback bot pushed a commit that referenced this pull request Apr 28, 2023
@felixfontein @patchback
passwordstore plugin: vendor FileLock that was removed from ansible-c…
a81dc16 
…ore devel (#6447)

Vendor FileLock that was removed from ansible-core devel.

(cherry picked from commit c58dda1)
@patchback patchback bot mentioned this pull request Apr 28, 2023
Merged
@patchback
Copy link

patchback bot commented Apr 28, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/c58dda14c203c3f60e093ccc6c18d4e0f2687a7e/pr-6447

Backported as #6450

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator Author

@russoz thanks for reviewing this!

patchback bot pushed a commit that referenced this pull request Apr 28, 2023
@felixfontein @patchback
passwordstore plugin: vendor FileLock that was removed from ansible-c…
f3e97d9 
…ore devel (#6447)

Vendor FileLock that was removed from ansible-core devel.

(cherry picked from commit c58dda1)
@patchback patchback bot mentioned this pull request Apr 28, 2023
Merged
felixfontein added a commit that referenced this pull request Apr 28, 2023
@patchback @felixfontein
[PR #6447/c58dda14 backport][stable-5] passwordstore plugin: vendor F…
98e0f0b 
…ileLock that was removed from ansible-core devel (#6449)

passwordstore plugin: vendor FileLock that was removed from ansible-core devel (#6447)

Vendor FileLock that was removed from ansible-core devel.

(cherry picked from commit c58dda1)

Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein added a commit that referenced this pull request Apr 28, 2023
@patchback @felixfontein
[PR #6447/c58dda14 backport][stable-6] passwordstore plugin: vendor F…
25b9391 
…ileLock that was removed from ansible-core devel (#6450)

passwordstore plugin: vendor FileLock that was removed from ansible-core devel (#6447)

Vendor FileLock that was removed from ansible-core devel.

(cherry picked from commit c58dda1)

Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russoz russoz russoz approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug lookup lookup plugin module_utils module_utils plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @russoz @ansibullbot