Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #6300/a35542d0 backport][stable-6] Rundeck modules fixes and improvements #6343

Merged
merged 1 commit into from
Apr 16, 2023
Merged

[PR #6300/a35542d0 backport][stable-6] Rundeck modules fixes and improvements #6343

merged 1 commit into from
Apr 16, 2023

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Apr 16, 2023

This is a backport of PR #6300 as merged into main (a35542d).

SUMMARY

Following PR #5887 and issue #5742, I've made some updates and improvements to the rundeck_acl_policy and rundeck_project modules to fix the issues and make them more standard.

Fixes #5742

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Refactoring Pull Request
COMPONENT NAME
  • rundeck_acl_policy
  • rundeck_project
ADDITIONAL INFORMATION
  • Changed the modules for using module_utils.rundeck functions and arguments
  • Fixed empty response errors in module_utils.rundeck

@phsmith @patchback
Rundeck modules fixes and improvements (#6300)
9be7a13 
* feat: add token alias to api_token parameter

* fix: return (None, info) on empty content response

* feat: update the modules for using module_utils.rundeck funcs

* docs: add changelog fragment

* fix: add trailing commas

* fix: changelog fragment invalid syntax

* fix: changelog typos

* fix: remove token aliases from api_token

* fix: add token alias to api_token param

* fix: add partial overwrite of params and docs

(cherry picked from commit a35542d)
@patchback patchback bot mentioned this pull request Apr 16, 2023
Merged
@ansibullbot
Copy link
Collaborator

cc @nerzhul
click here for bot help

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug module module module_utils module_utils needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) web_infrastructure and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Apr 16, 2023
@felixfontein felixfontein merged commit aa8728b into stable-6 Apr 16, 2023
@felixfontein felixfontein deleted the patchback/backports/stable-6/a35542d0d109df232f40a911f9ac31209d5dd4f1/pr-6300 branch April 16, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug module_utils module_utils module module new_contributor Help guide this first time contributor plugins plugin (any type) web_infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ansibullbot @felixfontein @phsmith