Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add worklog functionality to jira module #6210

Merged
merged 1 commit into from
Mar 26, 2023
Merged

Add worklog functionality to jira module #6210

merged 1 commit into from
Mar 26, 2023

Conversation

hugoprudente
Copy link
Contributor

SUMMARY

This adds the functionality to jira be able to add worklog comments.

Fixes #6209

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

community.general.jira

- name: Worklog on issue
  community.general.jira:
    uri: '{{ server }}'
    username: '{{ user }}'
    password: '{{ pass }}'
    issue: '{{ issue.meta.key }}'
    operation: worklog
    comment: A worklog added by Ansible
    fields:
      timeSpentSeconds: 12000

@ansibullbot
Copy link
Collaborator

cc @Slezhuk @pertoft @tarka
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) web_infrastructure labels Mar 20, 2023
@hugoprudente
Copy link
Contributor Author

Last commit adds the integration test that I forgot. Please let me know if something else is missing.

@ansibullbot ansibullbot added integration tests/integration tests tests labels Mar 20, 2023
@github-actions
Copy link

github-actions bot commented Mar 20, 2023 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot ansibullbot added the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI label Mar 21, 2023
@hugoprudente hugoprudente changed the title Fixes #6209 Add worklog functionality to jira Add worklog functionality to jira module Mar 21, 2023
@ansibullbot ansibullbot removed the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI label Mar 21, 2023
felixfontein
felixfontein reviewed Mar 22, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I've added some first comments below.

changelogs/fragments/6210-add-worklog-functionality-to-jira.yml Outdated Show resolved Hide resolved
plugins/modules/jira.py Show resolved Hide resolved
plugins/modules/jira.py Outdated Show resolved Hide resolved
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Mar 22, 2023
@hugoprudente
Copy link
Contributor Author

Hi @felixfontein addressed all the comments thanks for the initial review.

felixfontein
felixfontein reviewed Mar 22, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (without knowing or using jira). If nobody objects, I'll merge this for 6.5.0.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Mar 26, 2023
@felixfontein felixfontein merged commit be7f11b into ansible-collections:main Mar 26, 2023
@patchback
Copy link

patchback bot commented Mar 26, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/be7f11bf39183ae5d7ec103480b0a3ef760c2699/pr-6210

Backported as #6248

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@hugoprudente thanks for your contribution!

patchback bot pushed a commit that referenced this pull request Mar 26, 2023
@hugoprudente @patchback
Add worklog functionality to jira module (#6210)
8e4420a 
community.general#6209 Add worklog functionality to jira

(cherry picked from commit be7f11b)
@patchback patchback bot mentioned this pull request Mar 26, 2023
Merged
felixfontein pushed a commit that referenced this pull request Mar 26, 2023
@patchback @hugoprudente
[PR #6210/be7f11bf backport][stable-6] Add worklog functionality to j…
1260a63 
…ira module (#6248)

Add worklog functionality to jira module (#6210)

community.general#6209 Add worklog functionality to jira

(cherry picked from commit be7f11b)

Co-authored-by: Hugo Prudente <hugo.kenshin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests web_infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add worklog comment for Jira module
3 participants
@hugoprudente @ansibullbot @felixfontein