-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openbsd_pkg: set TERM to 'dumb' in execute_command #6149
openbsd_pkg: set TERM to 'dumb' in execute_command #6149
Conversation
Keeps pkg_add happy when someone running ansible is using a TERM that the managed OpenBSD host does not know about. Fixes ansible-collections#5738. Selection of specific TERM from discussion at https://marc.info/?l=openbsd-tech&m=167290482630534&w=2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Co-authored-by: Felix Fontein <felix@fontein.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I'll merge in a week if nobody objects.
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #6190 🤖 @patchback |
* openbsd_pkg: set TERM to 'dumb' in execute_command Keeps pkg_add happy when someone running ansible is using a TERM that the managed OpenBSD host does not know about. Fixes #5738. Selection of specific TERM from discussion at https://marc.info/?l=openbsd-tech&m=167290482630534&w=2 * Add changelog fragment for openbsd_pkg TERM fix * Update changelogs/fragments/6149-openbsd_pkg-term.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit b97bee3)
@eest thank you very much for your contribution! |
…' in execute_command (#6190) openbsd_pkg: set TERM to 'dumb' in execute_command (#6149) * openbsd_pkg: set TERM to 'dumb' in execute_command Keeps pkg_add happy when someone running ansible is using a TERM that the managed OpenBSD host does not know about. Fixes #5738. Selection of specific TERM from discussion at https://marc.info/?l=openbsd-tech&m=167290482630534&w=2 * Add changelog fragment for openbsd_pkg TERM fix * Update changelogs/fragments/6149-openbsd_pkg-term.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit b97bee3) Co-authored-by: Patrik Lundin <patrik@sigterm.se>
SUMMARY
Keeps pkg_add happy when someone running ansible is using a TERM that the managed OpenBSD host does not know about.
Fixes #5738.
Selection of specific TERM from discussion at
https://marc.info/?l=openbsd-tech&m=167290482630534&w=2
ISSUE TYPE
COMPONENT NAME
openbsd_pkg
ADDITIONAL INFORMATION
Before change:
After change:
I have run my test playbook (https://github.com/eest/openbsd_pkg-tests) with this change with a successful result.