Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nmcli: add runner_fast_rate option #6148

Merged
merged 4 commits into from
Mar 26, 2023
Merged

nmcli: add runner_fast_rate option #6148

merged 4 commits into from
Mar 26, 2023

Conversation

haddystuff
Copy link
Contributor

SUMMARY

This PR adds team.runner-fast-rate parameter support for nmcli module. Feature was requested in #6065

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/nmcli.py

@ansibullbot
Copy link
Collaborator

cc @alcamie101
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module net_tools plugins plugin (any type) tests tests unit tests/unit labels Mar 5, 2023
@github-actions
Copy link

github-actions bot commented Mar 5, 2023 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Mar 5, 2023
felixfontein
felixfontein reviewed Mar 7, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

plugins/modules/nmcli.py Outdated Show resolved Hide resolved
plugins/modules/nmcli.py Outdated Show resolved Hide resolved
@haddystuff
Copy link
Contributor Author

All suggested changes were made.

@haddystuff haddystuff requested a review from felixfontein March 8, 2023 14:39
felixfontein
felixfontein reviewed Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, looks good besides that!

plugins/modules/nmcli.py Outdated Show resolved Hide resolved
plugins/modules/nmcli.py Outdated Show resolved Hide resolved
plugins/modules/nmcli.py Outdated Show resolved Hide resolved
@haddystuff
Copy link
Contributor Author

All fixed

@haddystuff haddystuff requested a review from felixfontein March 9, 2023 21:45
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Mar 17, 2023
@haddystuff
Copy link
Contributor Author

Hi @felixfontein,
Any news regarding this PR?

This was referenced Mar 19, 2023
Merged
Merged
@felixfontein
Copy link
Collaborator

@jeffmcutter @heaveaxy @haddystuff there are currently multiple open PRs by you three for the nmcli module (#5974, #6106, #6105, #6107, #6108, #6148) which are waiting for reviews. Since I don't know nmcli well and am not maintaining this module, I would be glad if you could review each other's PRs. I'll gladly help with making sure that all formalities are OK and with merging, but I cannot really judge the PR changes themselves. Thanks :)

heaveaxy
heaveaxy suggested changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@heaveaxy heaveaxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one difference in argspecs in nmcli module file and tests. I commented this line, check it pls.
All others looking good to me.

tests/unit/plugins/modules/test_nmcli.py Outdated Show resolved Hide resolved
@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Mar 20, 2023
@felixfontein @heaveaxy
Remove default in copy of argspec.
55afdfe 
Co-authored-by: Sam Potekhin <eax24@ya.ru>
@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed stale_ci CI is older than 7 days, rerun before merging needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Mar 23, 2023
@felixfontein
Copy link
Collaborator

If nobody objects, I'll merge this weekend.

@felixfontein felixfontein merged commit d4f272b into ansible-collections:main Mar 26, 2023
@patchback
Copy link

patchback bot commented Mar 26, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/d4f272ba52840a752e09ccb6b21aca0aa94ce007/pr-6148

Backported as #6239

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Mar 26, 2023
patchback bot pushed a commit that referenced this pull request Mar 26, 2023
@haddystuff @patchback
nmcli: add runner_fast_rate option (#6148)
3749bbe 
* add runner_fast_rate option

* unset default value for runner_fast_rate parameter

* add some commas

* Remove default in copy of argspec.

Co-authored-by: Sam Potekhin <eax24@ya.ru>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Sam Potekhin <eax24@ya.ru>
(cherry picked from commit d4f272b)
@patchback patchback bot mentioned this pull request Mar 26, 2023
Merged
@felixfontein
Copy link
Collaborator

@haddystuff thanks for your contriution!
@heaveaxy thanks for reviewing!

felixfontein pushed a commit that referenced this pull request Mar 26, 2023
@patchback @haddystuff
[PR #6148/d4f272ba backport][stable-6] nmcli: add runner_fast_rate op…
4f78e79 
…tion (#6239)

nmcli: add runner_fast_rate option (#6148)

* add runner_fast_rate option

* unset default value for runner_fast_rate parameter

* add some commas

* Remove default in copy of argspec.

Co-authored-by: Sam Potekhin <eax24@ya.ru>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Sam Potekhin <eax24@ya.ru>
(cherry picked from commit d4f272b)

Co-authored-by: Alex Groshev <38885591+haddystuff@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heaveaxy heaveaxy heaveaxy requested changes

@felixfontein felixfontein Awaiting requested review from felixfontein

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR net_tools plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haddystuff @ansibullbot @felixfontein @heaveaxy