Updating yarn.list to not fail when when warnings are emitted #6129

JohnDaly · 2023-03-02T21:29:11Z

SUMMARY

Fixes #6127

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

yarn

ADDITIONAL INFORMATION

See #6127 for details

JohnDaly · 2023-03-02T21:31:37Z

plugins/modules/yarn.py

+        for line in error.splitlines():
+            if json.loads(line)['type'] == 'error':
+                self.module.fail_json(msg=error)


Using the same approach that yarn.list_outdated() is using, to filter out warnings and only fail on errors:

community.general/plugins/modules/yarn.py

Lines 285 to 288 in c0cb795

# the package.json in the global dir is missing a license field, so warnings are expected on stderr

for line in err.splitlines():

if json.loads(line)['type'] == 'error':

self.module.fail_json(msg=err)

ansibullbot · 2023-03-02T21:35:21Z

cc @chrishoffman @verkaufer
click here for bot help

felixfontein

Thanks for your contribution!

changelogs/fragments/6127-yarn-ignore-warnings.yml

plugins/modules/yarn.py

- Fixing formatting

plugins/modules/yarn.py

Co-authored-by: Felix Fontein <felix@fontein.de>

github-actions · 2023-03-05T02:16:25Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

felixfontein

Looks good to me. If nobody objects, I'll merge this in a week.

patchback · 2023-03-14T22:00:27Z

Backport to stable-5: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply df34569 on top of patchback/backports/stable-5/df34569fadca7f3b554f612d7480b1eb50919704/pr-6129

Backporting merged PR #6129 into main

Ensure you have a local repo clone of your fork. Unless you cloned it
from the upstream, this would be your origin remote.
Make sure you have an upstream repo added as a remote too. In these
instructions you'll refer to it by the name upstream. If you don't
have it, here's how you can add it:
```
$ git remote add upstream https://github.com/ansible-collections/community.general.git
```

Ensure you have the latest copy of upstream and prepare a branch
that will hold the backported code:

$ git fetch upstream
$ git checkout -b patchback/backports/stable-5/df34569fadca7f3b554f612d7480b1eb50919704/pr-6129 upstream/stable-5

Now, cherry-pick PR Updating yarn.list to not fail when when warnings are emitted #6129 contents into that branch:
```
$ git cherry-pick -x df34569fadca7f3b554f612d7480b1eb50919704
```
If it'll yell at you with something like fatal: Commit df34569fadca7f3b554f612d7480b1eb50919704 is a merge but no -m option was given., add -m 1 as follows instead:
```
$ git cherry-pick -m1 -x df34569fadca7f3b554f612d7480b1eb50919704
```
At this point, you'll probably encounter some merge conflicts. You must
resolve them in to preserve the patch from PR Updating yarn.list to not fail when when warnings are emitted #6129 as close to the
original as possible.

Push this branch to your fork on GitHub:

$ git push origin patchback/backports/stable-5/df34569fadca7f3b554f612d7480b1eb50919704/pr-6129

Create a PR, ensure that the CI is green. If it's not — update it so that
the tests and any other checks pass. This is it!
Now relax and wait for the maintainers to process your pull request
when they have some cycles to do reviews. Don't worry — they'll tell you if
any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback · 2023-03-14T22:00:34Z

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/df34569fadca7f3b554f612d7480b1eb50919704/pr-6129

Backported as #6189

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

* Updating yarn.list to not fail when when warnings are emitted * Adding changelog fragment * Adding _process_yarn_error function * - Adding back changes to the changelog fragment - Fixing formatting * Fix trailing whitespace * Update plugins/modules/yarn.py Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit df34569)

felixfontein · 2023-03-14T22:00:44Z

@JohnDaly thank you very much for your contribution!

… when when warnings are emitted (#6189) Updating yarn.list to not fail when when warnings are emitted (#6129) * Updating yarn.list to not fail when when warnings are emitted * Adding changelog fragment * Adding _process_yarn_error function * - Adding back changes to the changelog fragment - Fixing formatting * Fix trailing whitespace * Update plugins/modules/yarn.py Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit df34569) Co-authored-by: John Daly <john.daly2@gmail.com>

JohnDaly added 2 commits March 2, 2023 13:20

Updating yarn.list to not fail when when warnings are emitted

a2542f4

Adding changelog fragment

5b374ac

JohnDaly commented Mar 2, 2023

View reviewed changes

ansibullbot added bug This issue/PR relates to a bug language module module new_contributor Help guide this first time contributor packaging plugins plugin (any type) labels Mar 2, 2023

felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 labels Mar 3, 2023

felixfontein reviewed Mar 3, 2023

View reviewed changes

changelogs/fragments/6127-yarn-ignore-warnings.yml Outdated Show resolved Hide resolved

JohnDaly requested a review from felixfontein March 3, 2023 23:28

felixfontein reviewed Mar 4, 2023

View reviewed changes

plugins/modules/yarn.py Outdated Show resolved Hide resolved

Adding _process_yarn_error function

5411c7a

This comment was marked as outdated.

Sign in to view

ansibullbot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Mar 4, 2023

This comment was marked as outdated.

Sign in to view

ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Mar 4, 2023

JohnDaly force-pushed the fix/yarn-warnings branch from 87fd6b6 to 5411c7a Compare March 4, 2023 18:18

ansibullbot removed ci_verified Push fixes to PR branch to re-run CI merge_commit This PR contains at least one merge commit. Please resolve! labels Mar 4, 2023

ansibullbot added ci_verified Push fixes to PR branch to re-run CI and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Mar 4, 2023

- Adding back changes to the changelog fragment

24b0fe1

- Fixing formatting

ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label Mar 4, 2023

This comment was marked as outdated.

Sign in to view

ansibullbot added the ci_verified Push fixes to PR branch to re-run CI label Mar 4, 2023

Fix trailing whitespace

e4fe206

ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Mar 4, 2023

felixfontein reviewed Mar 4, 2023

View reviewed changes

plugins/modules/yarn.py Outdated Show resolved Hide resolved

Update plugins/modules/yarn.py

623b5c4

Co-authored-by: Felix Fontein <felix@fontein.de>

JohnDaly requested a review from felixfontein March 5, 2023 03:22

felixfontein approved these changes Mar 8, 2023

View reviewed changes

felixfontein merged commit df34569 into ansible-collections:main Mar 14, 2023

felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Mar 14, 2023

patchback bot mentioned this pull request Mar 14, 2023

[PR #6129/df34569f backport][stable-6] Updating yarn.list to not fail when when warnings are emitted #6189

Merged

JohnDaly deleted the fix/yarn-warnings branch March 14, 2023 22:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating yarn.list to not fail when when warnings are emitted #6129

Updating yarn.list to not fail when when warnings are emitted #6129

JohnDaly commented Mar 2, 2023

JohnDaly Mar 2, 2023

ansibullbot commented Mar 2, 2023

felixfontein left a comment

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Mar 5, 2023 •

edited

Loading

felixfontein left a comment

patchback bot commented Mar 14, 2023 •

edited

Loading

patchback bot commented Mar 14, 2023 •

edited

Loading

felixfontein commented Mar 14, 2023

	# the package.json in the global dir is missing a license field, so warnings are expected on stderr
	for line in err.splitlines():
	if json.loads(line)['type'] == 'error':
	self.module.fail_json(msg=err)

Updating yarn.list to not fail when when warnings are emitted #6129

Updating yarn.list to not fail when when warnings are emitted #6129

Conversation

JohnDaly commented Mar 2, 2023

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

JohnDaly Mar 2, 2023

Choose a reason for hiding this comment

ansibullbot commented Mar 2, 2023

felixfontein left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Mar 5, 2023 • edited Loading

Docs Build 📝

felixfontein left a comment

Choose a reason for hiding this comment

patchback bot commented Mar 14, 2023 • edited Loading

Backport to stable-5: 💔 cherry-picking failed — conflicts found

Backporting merged PR #6129 into main

patchback bot commented Mar 14, 2023 • edited Loading

Backport to stable-6: 💚 backport PR created

felixfontein commented Mar 14, 2023

github-actions bot commented Mar 5, 2023 •

edited

Loading

patchback bot commented Mar 14, 2023 •

edited

Loading

patchback bot commented Mar 14, 2023 •

edited

Loading