Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'inventory_hostname' to the jail plugin documentation #6118

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Add 'inventory_hostname' to the jail plugin documentation #6118

merged 1 commit into from
Mar 3, 2023

Conversation

olgeni
Copy link
Contributor

@olgeni olgeni commented Mar 1, 2023

SUMMARY

On FreeBSD, using the jail connection plugin will print the following warning when processing each task:

[WARNING]: The "jail" connection plugin has an improperly configured remote target value, forcing "inventory_hostname" templated value instead of the string

This was already fixed in other plugins by including "inventory_hostname" in the documentation string.

See for example 5e5af45 and 905f9ec.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • jail.py

@ansibullbot
Copy link
Collaborator

cc @None
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug connection connection plugin docs_only new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 labels Mar 1, 2023
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Could you please add a changelog fragment? Thanks!

This fixes the following warning on FreeBSD:

  [WARNING]: The "jail" connection plugin has an improperly configured
  remote target value, forcing "inventory_hostname" templated value
  instead of the string
@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed small_patch Hopefully easy to review labels Mar 3, 2023
@olgeni
Copy link
Contributor Author

olgeni commented Mar 3, 2023

Coming up ☝️

@ansibullbot ansibullbot removed docs_only needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Mar 3, 2023
@felixfontein felixfontein merged commit 9a97bc7 into ansible-collections:main Mar 3, 2023
@patchback
Copy link

patchback bot commented Mar 3, 2023

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/9a97bc7c1146f612e02268a8b6df92490ad10ec2/pr-6118

Backported as #6136

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Mar 3, 2023
patchback bot pushed a commit that referenced this pull request Mar 3, 2023
This fixes the following warning on FreeBSD:

  [WARNING]: The "jail" connection plugin has an improperly configured
  remote target value, forcing "inventory_hostname" templated value
  instead of the string

(cherry picked from commit 9a97bc7)
@felixfontein
Copy link
Collaborator

@olgeni thank you very much for fixing this!

@patchback
Copy link

patchback bot commented Mar 3, 2023

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/9a97bc7c1146f612e02268a8b6df92490ad10ec2/pr-6118

Backported as #6137

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 3, 2023
This fixes the following warning on FreeBSD:

  [WARNING]: The "jail" connection plugin has an improperly configured
  remote target value, forcing "inventory_hostname" templated value
  instead of the string

(cherry picked from commit 9a97bc7)
felixfontein pushed a commit that referenced this pull request Mar 3, 2023
…e jail plugin documentation (#6136)

Add 'inventory_hostname' to the jail plugin documentation (#6118)

This fixes the following warning on FreeBSD:

  [WARNING]: The "jail" connection plugin has an improperly configured
  remote target value, forcing "inventory_hostname" templated value
  instead of the string

(cherry picked from commit 9a97bc7)

Co-authored-by: Giacomo Olgeni <olgeni@olgeni.com>
felixfontein pushed a commit that referenced this pull request Mar 3, 2023
…e jail plugin documentation (#6137)

Add 'inventory_hostname' to the jail plugin documentation (#6118)

This fixes the following warning on FreeBSD:

  [WARNING]: The "jail" connection plugin has an improperly configured
  remote target value, forcing "inventory_hostname" templated value
  instead of the string

(cherry picked from commit 9a97bc7)

Co-authored-by: Giacomo Olgeni <olgeni@olgeni.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug connection connection plugin new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants