Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jenkins_plugin: avoid undefined variable when updates file is not downloaded #6100

Merged
merged 1 commit into from
Feb 26, 2023
Merged

jenkins_plugin: avoid undefined variable when updates file is not downloaded #6100

merged 1 commit into from
Feb 26, 2023

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Fixes #5898, which was introduced in #5565.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

jenkins_plugin

@felixfontein felixfontein mentioned this pull request Feb 26, 2023
Closed
1 task
@felixfontein felixfontein requested a review from russoz February 26, 2023 13:23
@ansibullbot
Copy link
Collaborator

cc @jtyr
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug has_issue module module plugins plugin (any type) web_infrastructure labels Feb 26, 2023
@github-actions
Copy link

github-actions bot commented Feb 26, 2023 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@felixfontein felixfontein merged commit e8bdec2 into ansible-collections:main Feb 26, 2023
@patchback
Copy link

patchback bot commented Feb 26, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/e8bdec27336d8d532b2224233c429d028f502211/pr-6100

Backported as #6103

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the jenkins branch February 26, 2023 14:37
@felixfontein
Copy link
Collaborator Author

@briantist thanks a lot for reviewing this!

patchback bot pushed a commit that referenced this pull request Feb 26, 2023
@felixfontein @patchback
jenkins_plugin: avoid undefined variable when updates file is not dow…
ce0688e 
…nloaded (#6100)

Avoid undefined variable when updates file is not downloaded.

(cherry picked from commit e8bdec2)
@patchback patchback bot mentioned this pull request Feb 26, 2023
Merged
felixfontein added a commit that referenced this pull request Feb 26, 2023
@patchback @felixfontein
[PR #6100/e8bdec27 backport][stable-6] jenkins_plugin: avoid undefine…
90a1743 
…d variable when updates file is not downloaded (#6103)

jenkins_plugin: avoid undefined variable when updates file is not downloaded (#6100)

Avoid undefined variable when updates file is not downloaded.

(cherry picked from commit e8bdec2)

Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briantist briantist briantist approved these changes

@russoz russoz Awaiting requested review from russoz

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug has_issue module module plugins plugin (any type) web_infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jenkins_plugin module has undefined Variable tmp_updates_file on update of plugins
3 participants
@felixfontein @ansibullbot @briantist