Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dig lookup: support CAA record type #5913

Merged
merged 2 commits into from
Jan 29, 2023
Merged

dig lookup: support CAA record type #5913

merged 2 commits into from
Jan 29, 2023

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

I borrowed some code from the dig lookup in ansible-collections/community.dns#133 and noticed that CAA records aren't supported by the dig lookup yet.

Since this is easy to fix, here we go :)

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

dig lookup plugin

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Jan 29, 2023
@ansibullbot
Copy link
Collaborator

cc @jpmens
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request lookup lookup plugin plugins plugin (any type) labels Jan 29, 2023
@github-actions
Copy link

github-actions bot commented Jan 29, 2023 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@jpmens
Copy link
Contributor

jpmens commented Jan 29, 2023

shipit

@felixfontein felixfontein removed check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 labels Jan 29, 2023
@felixfontein felixfontein merged commit 451c902 into ansible-collections:main Jan 29, 2023
@patchback
Copy link

patchback bot commented Jan 29, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/451c90251ad4b41e2f3b9a2c7e8bb557a1d5733f/pr-5913

Backported as #5917

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the dig branch January 29, 2023 17:19
patchback bot pushed a commit that referenced this pull request Jan 29, 2023
@felixfontein @patchback
dig lookup: support CAA record type (#5913)
04058cc 
* Support CAA record type.

* Update return docs.

(cherry picked from commit 451c902)
@patchback patchback bot mentioned this pull request Jan 29, 2023
Merged
@felixfontein
Copy link
Collaborator Author

@jpmens thanks for reviewing this one as well!

felixfontein added a commit that referenced this pull request Jan 29, 2023
@patchback @felixfontein
[PR #5913/451c9025 backport][stable-6] dig lookup: support CAA record…
24cf561 
… type (#5917)

dig lookup: support CAA record type (#5913)

* Support CAA record type.

* Update return docs.

(cherry picked from commit 451c902)

Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request lookup lookup plugin plugins plugin (any type) shipit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @ansibullbot @jpmens