add external user support to ipa_group module #5897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
feature
This comment was marked as outdated.
This comment was marked as outdated.
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
removed
ci_verified
felixfontein
added
check-before-release
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
ansibullbot
added
the
needs_revision
|
Thank you for prompt review @felixfontein! All the suggestions make sense. |
ansibullbot
removed
the
needs_revision
|
Thanks for the contribution! shipit |
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
ansibullbot
added
needs_ci
felixfontein
removed
the
check-before-release
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #5912 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 29, 2023
* add external user support to ipa_group module * add changelog * fix style errors * remove trailing whitespace * Update plugins/modules/ipa_group.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/ipa_group.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/ipa_group.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/ipa_group.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update changelogs/fragments/5897-ipa_group-add-external-users.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/ipa_group.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/ipa_group.py Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Yuriy Halytskyy <yuriy.halytskyy@nesi.org.nz> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 6c6de8f)
|
@yhal-nesi thanks for your contribution! |
felixfontein
pushed a commit
that referenced
this pull request
Jan 29, 2023
…pa_group module (#5912) add external user support to ipa_group module (#5897) * add external user support to ipa_group module * add changelog * fix style errors * remove trailing whitespace * Update plugins/modules/ipa_group.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/ipa_group.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/ipa_group.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/ipa_group.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update changelogs/fragments/5897-ipa_group-add-external-users.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/ipa_group.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/ipa_group.py Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Yuriy Halytskyy <yuriy.halytskyy@nesi.org.nz> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 6c6de8f) Co-authored-by: yhal003 <yuriy.halytskyy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ipa_group module allows declaring a group as external but doesn't allow adding external members. This pull request implements adding
ISSUE TYPE
COMPONENT NAME
ipa_group