Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iptables_state: minor pythonisms #5844

Merged
merged 3 commits into from
Jan 18, 2023
Merged

iptables_state: minor pythonisms #5844

merged 3 commits into from
Jan 18, 2023

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Jan 16, 2023

SUMMARY

Minor pythonifications.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/iptables_state.py

@ansibullbot
Copy link
Collaborator

cc @quidame
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module plugins plugin (any type) system labels Jan 16, 2023
@ansibullbot

This comment was marked as resolved.

Sign in to view
@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 16, 2023
@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 16, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Jan 16, 2023
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jan 18, 2023
@felixfontein felixfontein merged commit a35b2ed into ansible-collections:main Jan 18, 2023
@patchback
Copy link

patchback bot commented Jan 18, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/a35b2eda4c7dec53677063cb183a89b1236af608/pr-5844

Backported as #5855

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@russoz thanks!

patchback bot pushed a commit that referenced this pull request Jan 18, 2023
@russoz @patchback
iptables_state: minor pythonisms (#5844)
c7e57b5 
* iptables_state: minor pythonisms

* add changelog fragment

* fix typo

(cherry picked from commit a35b2ed)
@patchback patchback bot mentioned this pull request Jan 18, 2023
Merged
@russoz russoz deleted the iptables-state-refactor branch January 18, 2023 07:11
felixfontein pushed a commit that referenced this pull request Jan 18, 2023
@patchback @russoz
[PR #5844/a35b2eda backport][stable-6] iptables_state: minor pythonis…
ca177a0 
…ms (#5855)

iptables_state: minor pythonisms (#5844)

* iptables_state: minor pythonisms

* add changelog fragment

* fix typo

(cherry picked from commit a35b2ed)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request module module plugins plugin (any type) system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russoz @ansibullbot @felixfontein