Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to HPE iLO collection #5804

Merged
merged 4 commits into from
Jan 18, 2023

Conversation

Bhavya06
Copy link
Contributor

@Bhavya06 Bhavya06 commented Jan 9, 2023

SUMMARY

Minor changes in implementation of DNS and SNTP update.

Files changed -
ilo_redfish_config.py
ilo_redfish_utils.py

@ansibullbot
Copy link
Collaborator

@Bhavya06: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added module module module_utils module_utils needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly plugins plugin (any type) remote_management labels Jan 9, 2023
@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 9, 2023
@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_info This issue requires further information. Please answer any outstanding questions needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly labels Jan 9, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Jan 12, 2023
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Could you please add a changelog fragment? Thanks.

@github-actions
Copy link

github-actions bot commented Jan 16, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@mraineri
Copy link
Contributor

shipit

Co-authored-by: Felix Fontein <felix@fontein.de>
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jan 18, 2023
@felixfontein felixfontein merged commit b92542d into ansible-collections:main Jan 18, 2023
@patchback
Copy link

patchback bot commented Jan 18, 2023

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/b92542dea2bf542c95bc2f4b494276bda2a5d18f/pr-5804

Backported as #5854

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 18, 2023
* Minor changes to setting IPs of servers

* Lint fix

* Added change log

* Update changelogs/fragments/5804-minor-changes-to-hpe-ilo-collection.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit b92542d)
@felixfontein
Copy link
Collaborator

@Bhavya06 thanks for your contribution.
@mraineri thanks for reviewing.

felixfontein pushed a commit that referenced this pull request Jan 18, 2023
…ction (#5854)

Minor changes to HPE iLO collection (#5804)

* Minor changes to setting IPs of servers

* Lint fix

* Added change log

* Update changelogs/fragments/5804-minor-changes-to-hpe-ilo-collection.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit b92542d)

Co-authored-by: Bhavya <44067558+Bhavya06@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module_utils module_utils module module plugins plugin (any type) remote_management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants