Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apache2_module generates false/misleading warning #5793

Merged
merged 13 commits into from
Jan 14, 2023
Merged

apache2_module generates false/misleading warning #5793

merged 13 commits into from
Jan 14, 2023

Conversation

Warkdev
Copy link
Contributor

@Warkdev Warkdev commented Jan 7, 2023 •
edited
Loading

SUMMARY

Fixes #635

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

apache2_module

ADDITIONAL INFORMATION

@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot
Copy link
Collaborator

cc @berendt @n0trax
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress bug This issue/PR relates to a bug integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests web_infrastructure labels Jan 7, 2023
@Warkdev
Copy link
Contributor Author

Warkdev commented Jan 7, 2023

Issue reporter: @tw-alexb

felixfontein
felixfontein reviewed Jan 7, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

changelogs/fragments/5793-apache2-module-npm-warnings.yml Outdated Show resolved Hide resolved
plugins/modules/apache2_module.py Show resolved Hide resolved
plugins/modules/apache2_module.py Outdated Show resolved Hide resolved
tests/integration/targets/apache2_module/tasks/635-apache2-misleading-warning.yml Show resolved Hide resolved
tests/integration/targets/apache2_module/tasks/635-apache2-misleading-warning.yml Outdated Show resolved Hide resolved
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Jan 7, 2023
@felixfontein
Copy link
Collaborator

Bugfix Pull Request

Since you are adding a new option, this is a new feature, not a bugfix.

@Warkdev
Copy link
Contributor Author

Warkdev commented Jan 7, 2023

Indeed, description updated.

@ansibullbot
Copy link
Collaborator

@Warkdev this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jan 7, 2023
@github-actions
Copy link

github-actions bot commented Jan 7, 2023 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@felixfontein felixfontein removed the bug This issue/PR relates to a bug label Jan 7, 2023
@Warkdev Warkdev force-pushed the 635-apache2-misleading-warning branch from 9de496f to c00642d Compare January 8, 2023 13:26
@ansibullbot ansibullbot removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jan 8, 2023
@Warkdev Warkdev changed the title [WIP] apache2_module generates false/misleading warning apache2_module generates false/misleading warning Jan 8, 2023
@ansibullbot ansibullbot removed the WIP Work in progress label Jan 8, 2023
felixfontein
felixfontein approved these changes Jan 8, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! If nobody objects, I'll merge this in ~a week.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jan 14, 2023
@felixfontein felixfontein merged commit 756c077 into ansible-collections:main Jan 14, 2023
@patchback
Copy link

patchback bot commented Jan 14, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/756c0776d623ce928149db2d664451e549273ad8/pr-5793

Backported as #5841

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 14, 2023
@Warkdev @patchback
apache2_module generates false/misleading warning (#5793)
c5c11d7 
* Add parameter warn_mpm_module to control when warning are raised

* Remoe whitespace

* Add changelog fragment

* Add missing license

* Update changelogs/fragments/5793-apache2-module-npm-warnings.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/apache2_module.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/apache2_module.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update tests/integration/targets/apache2_module/tasks/635-apache2-misleading-warning.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Refining integration test - previous was invalid

* False to false

* refactor assertion for suse

* Revert "refactor assertion for suse"

This reverts commit 61b86e7.

* Excluding test on Suse

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 756c077)
@patchback patchback bot mentioned this pull request Jan 14, 2023
Merged
@felixfontein
Copy link
Collaborator

@Warkdev thanks for your contribution!

felixfontein pushed a commit that referenced this pull request Jan 14, 2023
@patchback @Warkdev
[PR #5793/756c0776 backport][stable-6] apache2_module generates false…
811c4a3 
…/misleading warning (#5841)

apache2_module generates false/misleading warning (#5793)

* Add parameter warn_mpm_module to control when warning are raised

* Remoe whitespace

* Add changelog fragment

* Add missing license

* Update changelogs/fragments/5793-apache2-module-npm-warnings.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/apache2_module.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/apache2_module.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update tests/integration/targets/apache2_module/tasks/635-apache2-misleading-warning.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Refining integration test - previous was invalid

* False to false

* refactor assertion for suse

* Revert "refactor assertion for suse"

This reverts commit 61b86e7.

* Excluding test on Suse

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 756c077)

Co-authored-by: Cédric Servais <cedric.servais@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests web_infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apache2_module generates false/misleading warning
3 participants
@Warkdev @ansibullbot @felixfontein