Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix callback plugin types #5761

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Fix callback plugin types #5761

merged 1 commit into from
Jan 4, 2023

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Some callback plugins were incorrectly classified as aggregate, even though they should be notification callbacks. (See https://docs.ansible.com/ansible/devel/plugins/callback.html#callback-plugins.)

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

loganalytics
logdna
logstash
splunk
sumologic
syslog_json

@ansibullbot
Copy link
Collaborator

cc @imjoseangel @ryancurrah @ujenmr @zhcli
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug callback callback plugin plugins plugin (any type) labels Jan 4, 2023
@felixfontein felixfontein merged commit 84ebda6 into ansible-collections:main Jan 4, 2023
@patchback
Copy link

patchback bot commented Jan 4, 2023 •
edited
Loading

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/84ebda65f1479b9b338bfca7294e4c28fba79576/pr-5761

Backported as #5762

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the callback-types branch January 4, 2023 21:07
patchback bot pushed a commit that referenced this pull request Jan 4, 2023
@felixfontein @patchback
Fix callback plugin types (#5761)
50b1f17 
Fix callback types.

(cherry picked from commit 84ebda6)
@patchback patchback bot mentioned this pull request Jan 4, 2023
Merged
@felixfontein
Copy link
Collaborator Author

@kristianheljas thanks for reviewing this!

@patchback
Copy link

patchback bot commented Jan 4, 2023 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/84ebda65f1479b9b338bfca7294e4c28fba79576/pr-5761

Backported as #5763

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 4, 2023
@felixfontein @patchback
Fix callback plugin types (#5761)
62d0f63 
Fix callback types.

(cherry picked from commit 84ebda6)
@patchback patchback bot mentioned this pull request Jan 4, 2023
Merged
@patchback
Copy link

patchback bot commented Jan 4, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/84ebda65f1479b9b338bfca7294e4c28fba79576/pr-5761

Backported as #5764

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 4, 2023
@felixfontein @patchback
Fix callback plugin types (#5761)
4bdf741 
Fix callback types.

(cherry picked from commit 84ebda6)
@patchback patchback bot mentioned this pull request Jan 4, 2023
Merged
felixfontein added a commit that referenced this pull request Jan 4, 2023
@patchback @felixfontein
[PR #5761/84ebda65 backport][stable-4] Fix callback plugin types (#5762)
9b13efe 
Fix callback plugin types (#5761)

Fix callback types.

(cherry picked from commit 84ebda6)

Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein added a commit that referenced this pull request Jan 4, 2023
@patchback @felixfontein
[PR #5761/84ebda65 backport][stable-5] Fix callback plugin types (#5763)
e7f66d9 
Fix callback plugin types (#5761)

Fix callback types.

(cherry picked from commit 84ebda6)

Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein added a commit that referenced this pull request Jan 4, 2023
@patchback @felixfontein
[PR #5761/84ebda65 backport][stable-6] Fix callback plugin types (#5764)
e08412c 
Fix callback plugin types (#5761)

Fix callback types.

(cherry picked from commit 84ebda6)

Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristianheljas kristianheljas kristianheljas approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug callback callback plugin plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @ansibullbot @kristianheljas