Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModuleHelper - fix bug when adjusting conflicting output #5755

Merged

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Jan 4, 2023

SUMMARY

Fix bug when adding _ as prefix to conflicting output variable names.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/module_utils/mh/module_helper.py

@ansibullbot ansibullbot added bug This issue/PR relates to a bug integration tests/integration module_utils module_utils plugins plugin (any type) tests tests labels Jan 4, 2023
@russoz russoz requested a review from felixfontein January 4, 2023 10:57
@felixfontein felixfontein merged commit b49bf08 into ansible-collections:main Jan 4, 2023
@patchback
Copy link

patchback bot commented Jan 4, 2023

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/b49bf081f8fce789f78cbf996d201c1ac99add01/pr-5755

Backported as #5756

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 4, 2023
* ModuleHelper - fix bug when adjusting conflicting output

* add changelog fragment

* remove commented test code

(cherry picked from commit b49bf08)
@patchback
Copy link

patchback bot commented Jan 4, 2023

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/b49bf081f8fce789f78cbf996d201c1ac99add01/pr-5755

Backported as #5757

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 4, 2023
* ModuleHelper - fix bug when adjusting conflicting output

* add changelog fragment

* remove commented test code

(cherry picked from commit b49bf08)
@patchback
Copy link

patchback bot commented Jan 4, 2023

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/b49bf081f8fce789f78cbf996d201c1ac99add01/pr-5755

Backported as #5758

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 4, 2023
* ModuleHelper - fix bug when adjusting conflicting output

* add changelog fragment

* remove commented test code

(cherry picked from commit b49bf08)
@felixfontein
Copy link
Collaborator

@russoz thanks for fixing this!

@russoz russoz deleted the mh-conflict-output branch January 4, 2023 11:02
felixfontein pushed a commit that referenced this pull request Jan 4, 2023
…justing conflicting output (#5756)

ModuleHelper - fix bug when adjusting conflicting output (#5755)

* ModuleHelper - fix bug when adjusting conflicting output

* add changelog fragment

* remove commented test code

(cherry picked from commit b49bf08)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
felixfontein pushed a commit that referenced this pull request Jan 4, 2023
…justing conflicting output (#5757)

ModuleHelper - fix bug when adjusting conflicting output (#5755)

* ModuleHelper - fix bug when adjusting conflicting output

* add changelog fragment

* remove commented test code

(cherry picked from commit b49bf08)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
felixfontein pushed a commit that referenced this pull request Jan 4, 2023
…justing conflicting output (#5758)

ModuleHelper - fix bug when adjusting conflicting output (#5755)

* ModuleHelper - fix bug when adjusting conflicting output

* add changelog fragment

* remove commented test code

(cherry picked from commit b49bf08)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug integration tests/integration module_utils module_utils plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants