Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd_runner: allow bool format to pass alternate (false) value #5647

Merged
merged 2 commits into from
Dec 4, 2022
Merged

cmd_runner: allow bool format to pass alternate (false) value #5647

merged 2 commits into from
Dec 4, 2022

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Dec 4, 2022

SUMMARY

Allow cmd_runner_fmt.as_bool() to take an extra argument that will be formatted if value is False.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/module_utils/cmd_runner.py

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module_utils module_utils plugins plugin (any type) tests tests unit tests/unit labels Dec 4, 2022
@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Dec 4, 2022
@felixfontein felixfontein merged commit be22ca0 into ansible-collections:main Dec 4, 2022
@patchback
Copy link

patchback bot commented Dec 4, 2022 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/be22ca063354507fbafb6d55032be39636bbf036/pr-5647

Backported as #5650

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@russoz thanks!

patchback bot pushed a commit that referenced this pull request Dec 4, 2022
@russoz @patchback
cmd_runner: allow bool format to pass alternate (false) value (#5647)
7dac14d 
* allow bool format to pass alternate (false) value

* add changelog fragment

(cherry picked from commit be22ca0)
@patchback patchback bot mentioned this pull request Dec 4, 2022
Merged
felixfontein pushed a commit that referenced this pull request Dec 4, 2022
@patchback @russoz
[PR #5647/be22ca06 backport][stable-6] cmd_runner: allow bool format …
cc28cde 
…to pass alternate (false) value (#5650)

cmd_runner: allow bool format to pass alternate (false) value (#5647)

* allow bool format to pass alternate (false) value

* add changelog fragment

(cherry picked from commit be22ca0)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
@russoz russoz deleted the cmd-runner-format-bool-false branch December 4, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request module_utils module_utils plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russoz @felixfontein @ansibullbot