Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect and Remove sap modules #5592

Merged
merged 11 commits into from
Nov 27, 2022
Merged

Redirect and Remove sap modules #5592

merged 11 commits into from
Nov 27, 2022

Conversation

rainerleber
Copy link
Contributor

SUMMARY

Remove sap relevant modules because of migration to community.sap_libs

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

sapcar_extract
hana_query
sap_task_list_execute

ADDITIONAL INFORMATION

@ansibullbot
Copy link
Collaborator

cc @rainerleber
click here for bot help

@ansibullbot ansibullbot added database files module module new_plugin New plugin plugins plugin (any type) system tests tests unit tests/unit labels Nov 23, 2022
@github-actions
Copy link

github-actions bot commented Nov 23, 2022 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@rainerleber
Copy link
Contributor Author

@felixfontein i opened a new pr because of file structure changes

@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Nov 23, 2022
felixfontein
felixfontein reviewed Nov 23, 2022
View reviewed changes
meta/runtime.yml Outdated Show resolved Hide resolved
changelogs/fragments/5592-redirect-remove-sap-modules.yml Outdated Show resolved Hide resolved
@felixfontein felixfontein added breaking_change This PR contains a breaking change that MUST NOT be backported check-before-release PR will be looked at again shortly before release and merged if possible. labels Nov 23, 2022
@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Nov 23, 2022
@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI labels Nov 25, 2022
rainerleber and others added 3 commits November 27, 2022 07:51
@rainerleber @felixfontein
Update meta/runtime.yml
0152bd8 
Co-authored-by: Felix Fontein <felix@fontein.de>
@rainerleber @felixfontein
Update changelogs/fragments/5592-redirect-remove-sap-modules.yml
c631ac1 
Co-authored-by: Felix Fontein <felix@fontein.de>
@rainerleber @felixfontein
Update changelogs/fragments/5592-redirect-remove-sap-modules.yml
5b45ae5 
Co-authored-by: Felix Fontein <felix@fontein.de>
@ansibullbot

This comment was marked as outdated.

Sign in to view
felixfontein
felixfontein reviewed Nov 27, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't _libs missing in both these places?

meta/runtime.yml Outdated Show resolved Hide resolved
meta/runtime.yml Outdated Show resolved Hide resolved
rainerleber and others added 2 commits November 27, 2022 13:35
@rainerleber @felixfontein
Update meta/runtime.yml
91711c1 
Co-authored-by: Felix Fontein <felix@fontein.de>
@rainerleber @felixfontein
Update meta/runtime.yml
7e5cafa 
Co-authored-by: Felix Fontein <felix@fontein.de>
@rainerleber
Copy link
Contributor Author

Isn't _libs missing in both these places?

Yes it is thanks for the hint 😀

@ansibullbot ansibullbot added the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI label Nov 27, 2022
@felixfontein felixfontein mentioned this pull request Nov 27, 2022
Merged
@ansibullbot ansibullbot removed the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI label Nov 27, 2022
@felixfontein felixfontein merged commit b1094d8 into ansible-collections:main Nov 27, 2022
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 27, 2022
@felixfontein
Copy link
Collaborator

@rainerleber thanks for taking care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
breaking_change This PR contains a breaking change that MUST NOT be backported database files module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_plugin New plugin plugins plugin (any type) system tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rainerleber @ansibullbot @felixfontein