chroot plugin fix inventory_hostname var for remote_addr #5570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ugin required by ansible 2.13
ansibullbot
added
bug
|
The test The test The test The test The test The test |
ansibullbot
added
ci_verified
Docs Build 📝Thank you for contribution!✨ The docsite for this PR is available for download as an artifact from this run: File changes:
Click to see the diff comparison.NOTE: only file modifications are shown here. New and deleted files are excluded. diff --git a/home/runner/work/community.general/community.general/docsbuild/base/collections/community/general/chroot_connection.html b/home/runner/work/community.general/community.general/docsbuild/head/collections/community/general/chroot_connection.html
index b3e63c8..1f02787 100644
--- a/home/runner/work/community.general/community.general/docsbuild/base/collections/community/general/chroot_connection.html
+++ b/home/runner/work/community.general/community.general/docsbuild/head/collections/community/general/chroot_connection.html
@@ -206,6 +206,7 @@
<p class="ansible-option-line"><span class="ansible-option-default-bold">Default:</span> <code class="ansible-option-default docutils literal notranslate"><span class="pre">"inventory_hostname"</span></code></p>
<p class="ansible-option-line"><span class="ansible-option-configuration">Configuration:</span></p>
<ul class="simple">
+<li><p>Variable: inventory_hostname</p></li>
<li><p>Variable: ansible_host</p></li>
</ul>
</div></td>
|
ansibullbot
removed
ci_verified
felixfontein
added
check-before-release
felixfontein
approved these changes
Nov 17, 2022
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #5572 🤖 @patchback |
felixfontein
removed
the
check-before-release
patchback bot
pushed a commit
that referenced
this pull request
Nov 17, 2022
* Add inventory_hostname under remote_addr.vars in chroot connection plugin required by ansible 2.13 * fix changelog fragment (cherry picked from commit 5e5af45)
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #5573 🤖 @patchback |
|
@evanjarrett thanks for your contribution! |
patchback bot
pushed a commit
that referenced
this pull request
Nov 17, 2022
* Add inventory_hostname under remote_addr.vars in chroot connection plugin required by ansible 2.13 * fix changelog fragment (cherry picked from commit 5e5af45)
felixfontein
pushed a commit
that referenced
this pull request
Nov 17, 2022
felixfontein
pushed a commit
that referenced
this pull request
Nov 17, 2022
russoz
pushed a commit
to russoz-ansible/community.general
that referenced
this pull request
Nov 27, 2022
…lections#5570) * Add inventory_hostname under remote_addr.vars in chroot connection plugin required by ansible 2.13 * fix changelog fragment
russoz
pushed a commit
to russoz-ansible/community.general
that referenced
this pull request
Nov 27, 2022
…lections#5570) * Add inventory_hostname under remote_addr.vars in chroot connection plugin required by ansible 2.13 * fix changelog fragment
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add inventory_hostname to the vars under remote_addr to fix compatibility with ansible-core 2.13
A similar change was made to the lxd plugin here #4912
ISSUE TYPE
COMPONENT NAME
chroot connection plugin
ADDITIONAL INFORMATION
remote_addr value was being set to literal string 'inventory_hostname' instead of value of inventory_hostname variable.
Adding inventory_hostname to the vars: directive prevents the warnings as specified in https://github.com/ansible/ansible/blob/devel/lib/ansible/playbook/play_context.py#L320