Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional flags to nmap.py #5566

Merged
merged 14 commits into from
Nov 17, 2022
Merged

Add additional flags to nmap.py #5566

merged 14 commits into from
Nov 17, 2022

Conversation

dstuart
Copy link
Contributor

@dstuart dstuart commented Nov 16, 2022

SUMMARY

Adding udp scan, icmp timestamp and dns resolve flag options to scanning for inventory. This allows for machines that aren't available via standard scans or ports are filtered for security.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

Extending existing nmap inventory scan

ADDITIONAL INFORMATION

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request inventory inventory plugin new_contributor Help guide this first time contributor plugins plugin (any type) labels Nov 16, 2022
@dstuart dstuart mentioned this pull request Nov 16, 2022
Open
1 task
@dstuart dstuart mentioned this pull request Nov 16, 2022
Closed
1 task
@github-actions
Copy link

github-actions bot commented Nov 16, 2022 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Nov 16, 2022
felixfontein
felixfontein reviewed Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Could you please add a changelog fragment? Thanks.

plugins/inventory/nmap.py Outdated Show resolved Hide resolved
plugins/inventory/nmap.py Show resolved Hide resolved
plugins/inventory/nmap.py Outdated Show resolved Hide resolved
plugins/inventory/nmap.py Show resolved Hide resolved
plugins/inventory/nmap.py Show resolved Hide resolved
plugins/inventory/nmap.py Outdated Show resolved Hide resolved
plugins/inventory/nmap.py Outdated Show resolved Hide resolved
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Nov 16, 2022
dstuart and others added 3 commits November 16, 2022 21:25
@dstuart
Updates as per felixfontein suggestions
db2084e
@dstuart @felixfontein
Update plugins/inventory/nmap.py
8b04a29 
Co-authored-by: Felix Fontein <felix@fontein.de>
@dstuart @felixfontein
Update plugins/inventory/nmap.py
2dc4fce 
Co-authored-by: Felix Fontein <felix@fontein.de>
@ansibullbot
Copy link
Collaborator

@dstuart this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 16, 2022
@dstuart @felixfontein
Update changelogs/fragments/5566-additional-flags-nmap.yml
35fbd09 
Co-authored-by: Felix Fontein <felix@fontein.de>
@ansibullbot ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label Nov 16, 2022
@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Nov 16, 2022
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 17, 2022
@felixfontein felixfontein merged commit 52c2849 into ansible-collections:main Nov 17, 2022
@patchback
Copy link

patchback bot commented Nov 17, 2022 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/52c28494ca903642aa4278afb580321302d119c9/pr-5566

Backported as #5576

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@dstuart thanks for your contribution!

patchback bot pushed a commit that referenced this pull request Nov 17, 2022
@dstuart @patchback
Add additional flags to nmap.py (#5566)
2d1b24d 
* Adding extra flag options for NMAP scaning udp_scan, icmp_timestamp and dns_resolve

* Update nmap.py

* Update plugins/inventory/nmap.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Updates as per felixfontein  suggestions

* Updates as per felixfontein  suggestions

* Update plugins/inventory/nmap.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/inventory/nmap.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update nmap.py

* Update changelogs/fragments/5566-additional-flags-nmap.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update changelogs/fragments/5566-additional-flags-nmap.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update 5566-additional-flags-nmap.yml

* Update nmap.py

Co-authored-by: Axis12 <3225945+axistwelve@users.noreply.github.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 52c2849)
@patchback patchback bot mentioned this pull request Nov 17, 2022
Merged
felixfontein pushed a commit that referenced this pull request Nov 23, 2022
@patchback @dstuart
Add additional flags to nmap.py (#5566) (#5576)
5ebd980 
* Adding extra flag options for NMAP scaning udp_scan, icmp_timestamp and dns_resolve

* Update nmap.py

* Update plugins/inventory/nmap.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Updates as per felixfontein  suggestions

* Updates as per felixfontein  suggestions

* Update plugins/inventory/nmap.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/inventory/nmap.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update nmap.py

* Update changelogs/fragments/5566-additional-flags-nmap.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update changelogs/fragments/5566-additional-flags-nmap.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update 5566-additional-flags-nmap.yml

* Update nmap.py

Co-authored-by: Axis12 <3225945+axistwelve@users.noreply.github.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 52c2849)

Co-authored-by: David Stuart <dave@axistwelve.com>
russoz pushed a commit to russoz-ansible/community.general that referenced this pull request Nov 27, 2022
@dstuart @axistwelve
@felixfontein @russoz
Add additional flags to nmap.py (ansible-collections#5566)
93d3164 
* Adding extra flag options for NMAP scaning udp_scan, icmp_timestamp and dns_resolve

* Update nmap.py

* Update plugins/inventory/nmap.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Updates as per felixfontein  suggestions

* Updates as per felixfontein  suggestions

* Update plugins/inventory/nmap.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/inventory/nmap.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update nmap.py

* Update changelogs/fragments/5566-additional-flags-nmap.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update changelogs/fragments/5566-additional-flags-nmap.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update 5566-additional-flags-nmap.yml

* Update nmap.py

Co-authored-by: Axis12 <3225945+axistwelve@users.noreply.github.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
russoz pushed a commit to russoz-ansible/community.general that referenced this pull request Nov 27, 2022
@dstuart @axistwelve
@felixfontein @russoz
Add additional flags to nmap.py (ansible-collections#5566)
ccb5797 
* Adding extra flag options for NMAP scaning udp_scan, icmp_timestamp and dns_resolve

* Update nmap.py

* Update plugins/inventory/nmap.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Updates as per felixfontein  suggestions

* Updates as per felixfontein  suggestions

* Update plugins/inventory/nmap.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/inventory/nmap.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update nmap.py

* Update changelogs/fragments/5566-additional-flags-nmap.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update changelogs/fragments/5566-additional-flags-nmap.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update 5566-additional-flags-nmap.yml

* Update nmap.py

Co-authored-by: Axis12 <3225945+axistwelve@users.noreply.github.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request has_issue inventory inventory plugin merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dstuart @ansibullbot @felixfontein @axistwelve