Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gconftool2: refactored to use ModuleHelper + CmdRunner #5545

Merged
merged 3 commits into from
Nov 15, 2022
Merged

gconftool2: refactored to use ModuleHelper + CmdRunner #5545

merged 3 commits into from
Nov 15, 2022

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Nov 15, 2022

SUMMARY

Refactor to use ModuleHelper and CmdRunner.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/gconftool2.py

@ansibullbot
Copy link
Collaborator

cc @Akasurde @kevensen
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module module_utils module_utils new_plugin New plugin plugins plugin (any type) system tests tests unit tests/unit needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 15, 2022
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Nov 15, 2022
@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 15, 2022
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 15, 2022
@felixfontein felixfontein merged commit 6c7e911 into ansible-collections:main Nov 15, 2022
@patchback
Copy link

patchback bot commented Nov 15, 2022 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/6c7e9116e1abba6c125e7f05cf7fd0e8042a1f43/pr-5545

Backported as #5551

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@russoz thanks for your contribution!

patchback bot pushed a commit that referenced this pull request Nov 15, 2022
@russoz @patchback
gconftool2: refactored to use ModuleHelper + CmdRunner (#5545)
0a63c3f 
* gconftool2: refactored to use ModuleHelper + CmdRunner

* add changelog fragment

* removed old code commented out

(cherry picked from commit 6c7e911)
@patchback patchback bot mentioned this pull request Nov 15, 2022
Merged
@russoz russoz deleted the gconftool2-cmd-runner branch November 15, 2022 20:58
felixfontein pushed a commit that referenced this pull request Nov 23, 2022
@patchback @russoz
gconftool2: refactored to use ModuleHelper + CmdRunner (#5545) (#5551)
b52a6f3 
* gconftool2: refactored to use ModuleHelper + CmdRunner

* add changelog fragment

* removed old code commented out

(cherry picked from commit 6c7e911)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request module_utils module_utils module module new_plugin New plugin plugins plugin (any type) system tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russoz @ansibullbot @felixfontein