Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependent lookup: prevent deprecation warning with ansible-core 2.14 #5543

Merged
merged 2 commits into from
Nov 15, 2022
Merged

dependent lookup: prevent deprecation warning with ansible-core 2.14 #5543

merged 2 commits into from
Nov 15, 2022

Conversation

felixfontein
Copy link
Collaborator

SUMMARY
[DEPRECATION WARNING]: The `cache` option to `Templar.template` is no longer functional, and will be removed in a future release. This feature will be removed in version 2.18. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

dependent lookup

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 labels Nov 14, 2022
@ansibullbot ansibullbot added bug This issue/PR relates to a bug lookup lookup plugin plugins plugin (any type) needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 14, 2022
@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 14, 2022
@felixfontein felixfontein merged commit 60c8b9a into ansible-collections:main Nov 15, 2022
@patchback
Copy link

patchback bot commented Nov 15, 2022 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/60c8b9a67fe0788c770db69641ca6552beb2f522/pr-5543

Backported as #5547

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the dependent branch November 15, 2022 07:12
@felixfontein
Copy link
Collaborator Author

@markuman thank you very much for reviewing this!

patchback bot pushed a commit that referenced this pull request Nov 15, 2022
@felixfontein @patchback
dependent lookup: prevent deprecation warning with ansible-core 2.14 (#…
14a5f84 
…5543)

* Prevent deprecation warning.

* Improve naming and add comment.

(cherry picked from commit 60c8b9a)
@patchback patchback bot mentioned this pull request Nov 15, 2022
Merged
@patchback
Copy link

patchback bot commented Nov 15, 2022 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/60c8b9a67fe0788c770db69641ca6552beb2f522/pr-5543

Backported as #5548

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 15, 2022
@felixfontein @patchback
dependent lookup: prevent deprecation warning with ansible-core 2.14 (#…
5e89b85 
…5543)

* Prevent deprecation warning.

* Improve naming and add comment.

(cherry picked from commit 60c8b9a)
@patchback patchback bot mentioned this pull request Nov 15, 2022
Merged
felixfontein added a commit that referenced this pull request Nov 15, 2022
@patchback @felixfontein
dependent lookup: prevent deprecation warning with ansible-core 2.14 (#…
9c4487e 
…5543) (#5548)

* Prevent deprecation warning.

* Improve naming and add comment.

(cherry picked from commit 60c8b9a)

Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein added a commit that referenced this pull request Nov 15, 2022
@patchback @felixfontein
dependent lookup: prevent deprecation warning with ansible-core 2.14 (#…
b23fdc3 
…5543) (#5547)

* Prevent deprecation warning.

* Improve naming and add comment.

(cherry picked from commit 60c8b9a)

Co-authored-by: Felix Fontein <felix@fontein.de>
konstruktoid pushed a commit to konstruktoid/community.general that referenced this pull request Nov 15, 2022
@felixfontein @konstruktoid
dependent lookup: prevent deprecation warning with ansible-core 2.14 (a…
9ca1ca4 
…nsible-collections#5543)

* Prevent deprecation warning.

* Improve naming and add comment.
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuman markuman markuman approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug lookup lookup plugin plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @markuman @ansibullbot