Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scaleway module utils: make function private that should be removed #5499

Merged
merged 5 commits into from
Jan 18, 2023
Merged

scaleway module utils: make function private that should be removed #5499

merged 5 commits into from
Jan 18, 2023

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Removing it in #5497 triggered a pylint bug. This tries to at least make it private.

ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request
COMPONENT NAME

scaleway module utils

@felixfontein felixfontein mentioned this pull request Nov 7, 2022
Merged
@ansibullbot
Copy link
Collaborator

cc @abarbare @remyleone
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug cloud module_utils module_utils plugins plugin (any type) small_patch Hopefully easy to review labels Nov 7, 2022
@felixfontein
Copy link
Collaborator Author

Hmm, pylint really doesn't want us to touch that function, it seems :-(

@ansibullbot ansibullbot removed the small_patch Hopefully easy to review label Nov 7, 2022
@felixfontein
Copy link
Collaborator Author

Ok, I give up... :-(

@felixfontein felixfontein changed the title scaleway module utils: make function private that should be removed [WIP] scaleway module utils: make function private that should be removed Nov 7, 2022
@ansibullbot ansibullbot added the WIP Work in progress label Nov 7, 2022
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Nov 15, 2022
@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Jan 18, 2023
@felixfontein
Copy link
Collaborator Author

Yay, the tests stopped failing! 🎉 Let's get this merged.

@felixfontein felixfontein changed the title [WIP] scaleway module utils: make function private that should be removed scaleway module utils: make function private that should be removed Jan 18, 2023
@felixfontein felixfontein merged commit c4b1836 into ansible-collections:main Jan 18, 2023
@patchback
Copy link

patchback bot commented Jan 18, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/c4b18361b990fac683e0438a154eeac23b38d590/pr-5499

Backported as #5860

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the scaleway-private branch January 18, 2023 20:32
patchback bot pushed a commit that referenced this pull request Jan 18, 2023
@felixfontein @patchback
scaleway module utils: make function private that should be removed (#…
1dad109 
…5499)

* Make function private that should be removed (ref: #5497).

* Maybe it works as a comment?

* Try something else.

* Ok, let's just add a comment.

* Last try: docstring instead of comment.

(cherry picked from commit c4b1836)
@patchback patchback bot mentioned this pull request Jan 18, 2023
Merged
felixfontein added a commit that referenced this pull request Jan 18, 2023
@patchback @felixfontein
[PR #5499/c4b18361 backport][stable-6] scaleway module utils: make fu…
60addb3 
…nction private that should be removed (#5860)

scaleway module utils: make function private that should be removed (#5499)

* Make function private that should be removed (ref: #5497).

* Maybe it works as a comment?

* Try something else.

* Ok, let's just add a comment.

* Last try: docstring instead of comment.

(cherry picked from commit c4b1836)

Co-authored-by: Felix Fontein <felix@fontein.de>
@github-actions
Copy link

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug cloud module_utils module_utils plugins plugin (any type) WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixfontein @ansibullbot