Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mksysb: using CmdRunner #5484

Merged
merged 4 commits into from
Nov 7, 2022
Merged

mksysb: using CmdRunner #5484

merged 4 commits into from
Nov 7, 2022

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Nov 7, 2022 •
edited
Loading

SUMMARY

mksysb now using CmdRunner instead of CmdModuleHelper

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/mksysb.py

@ansibullbot
Copy link
Collaborator

cc @MorrisA @bcoca @d-little @flynn1973 @gforster @kairoaraujo @marvin-sinister @mator @molekuul @ramooncamacho @wtcross
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module plugins plugin (any type) system labels Nov 7, 2022
@felixfontein felixfontein added the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 7, 2022
@ansibullbot
Copy link
Collaborator

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

plugins/modules/mksysb.py:155:23: E127: continuation line over-indented for visual indent

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

plugins/modules/mksysb.py:155:23: E127: continuation line over-indented for visual indent

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

plugins/modules/mksysb.py:155:23: E127: continuation line over-indented for visual indent

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

plugins/modules/mksysb.py:155:23: E127: continuation line over-indented for visual indent

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

plugins/modules/mksysb.py:155:23: E127: continuation line over-indented for visual indent

click here for bot help

@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 7, 2022
@russoz @felixfontein
Update plugins/modules/mksysb.py
f05786f 
Co-authored-by: Felix Fontein <felix@fontein.de>
@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI and removed ci_verified Push fixes to PR branch to re-run CI needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 7, 2022
@felixfontein felixfontein merged commit 8758f6a into ansible-collections:main Nov 7, 2022
@felixfontein
Copy link
Collaborator

@russoz thanks!

@russoz russoz deleted the mksysb-cmd-runner branch November 7, 2022 20:45
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 7, 2022
russoz added a commit to russoz-ansible/community.general that referenced this pull request Nov 10, 2022
@russoz @felixfontein
mksysb: using CmdRunner (ansible-collections#5484)
37f065b 
* mksysb: using CmdRunner

* add changelog fragment

* adjust code when check_mode true

* Update plugins/modules/mksysb.py

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request module module plugins plugin (any type) system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russoz @ansibullbot @felixfontein