Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #5435/1a97ca1a backport][stable-5] ldap_attrs: escape ldap search filter #5469

Merged
merged 1 commit into from
Nov 4, 2022
Merged

[PR #5435/1a97ca1a backport][stable-5] ldap_attrs: escape ldap search filter #5469

merged 1 commit into from
Nov 4, 2022

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Nov 4, 2022

This is a backport of PR #5435 as merged into main (1a97ca1).

SUMMARY

Escape ldap search parameter before passing it to search_s

Fixes #5434

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ldap_attrs

@rekup @patchback
ldap_attrs: escape ldap search filter (#5435)
fdaf786 
* escape ldap search filter

* move escape to separate line

* add changelog fragment

* Update changelogs/fragments/5435-escape-ldap-param.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* fix encoding

* fixup! fix encoding

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 1a97ca1)
@patchback patchback bot mentioned this pull request Nov 4, 2022
Merged
@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Nov 4, 2022
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

❗ No coverage uploaded for pull request base (stable-5@24a4d6e). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 1a97ca1 differs from pull request most recent head fdaf786. Consider uploading reports for the commit fdaf786 to get more accurate results

@@             Coverage Diff             @@
##             stable-5    #5469   +/-   ##
===========================================
  Coverage            ?   45.50%           
===========================================
  Files               ?      988           
  Lines               ?    97113           
  Branches            ?    17743           
===========================================
  Hits                ?    44191           
  Misses              ?    50878           
  Partials            ?     2044
Flag Coverage Δ
integration 71.22% <0.00%> (?)
sanity 21.31% <0.00%> (?)
stub 0.00% <0.00%> (?)
units 68.14% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@felixfontein felixfontein merged commit b726110 into stable-5 Nov 4, 2022
@felixfontein felixfontein deleted the patchback/backports/stable-5/1a97ca1a6f77cabca78d18bfd8a9f46939f11f8a/pr-5435 branch November 4, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @ansibullbot @rekup