ldap_attrs: search_s based _is_value_present #5385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Thanks for your contribution! Please add a changelog fragment. Thanks.
felixfontein
added
check-before-release
|
I wonder why the tests fail on importing ldap in ldap_attrs.py? What can be done? |
|
Before merging: I see that ldap_entry.py only catches |
changelogs/fragments/5385-search_s-based-_is_value_present.yaml
Outdated
Show resolved
Hide resolved
|
CI is happy and there's nothing I want to change. How to proceed from here? |
|
@mrvanes basically this is waiting for a review by the module maintainers. |
changelogs/fragments/5385-search_s-based-_is_value_present.yaml
Outdated
Show resolved
Hide resolved
ansibullbot
removed
the
needs_revision
felixfontein
changed the title
This was referenced Nov 20, 2022
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #977
ISSUE TYPE
COMPONENT NAME
community.general.ldap_attrs
ADDITIONAL INFORMATION
Instead of comparing the dn's attribute values using compare_s, I suggest using search_s plus filter, because search is X-ORDERED agnostic.