MH CmdModuleHelper: deprecation #5370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
feature
ansibullbot
added
the
needs_revision
felixfontein
added
check-before-release
| self.module.deprecate( | ||
| 'The CmdMixin used in classes CmdModuleHelper and CmdStateModuleHelper is being deprecated. ' | ||
| 'Modules should use community.general.plugins.module_utils.cmd_runner.CmdRunner instead.', | ||
| version='8.0.0', |
There was a problem hiding this comment.
In case it turns out someone from outside this collection is relying on it, we should bump this up to 9.0.0. But as long as nobody is complaining, let's keep 8.0.0 :)
felixfontein
approved these changes
Oct 23, 2022
|
The remaining CI failures are unrelated. |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #5413 🤖 @patchback |
felixfontein
removed
the
check-before-release
patchback bot
pushed a commit
that referenced
this pull request
Oct 23, 2022
* MH CmdModuleHelper: deprecation * add changelog fragment * add deprecation comments in many parts of the code (cherry picked from commit 91cac4c)
|
@russoz thanks! |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
felixfontein
pushed a commit
that referenced
this pull request
Oct 23, 2022
russoz
added a commit
to russoz-ansible/community.general
that referenced
this pull request
Nov 5, 2022
* MH CmdModuleHelper: deprecation * add changelog fragment * add deprecation comments in many parts of the code
bratwurzt
pushed a commit
to bratwurzt/community.general
that referenced
this pull request
Nov 7, 2022
* MH CmdModuleHelper: deprecation * add changelog fragment * add deprecation comments in many parts of the code
bratwurzt
pushed a commit
to bratwurzt/community.general
that referenced
this pull request
Nov 7, 2022
* MH CmdModuleHelper: deprecation * add changelog fragment * add deprecation comments in many parts of the code
1 task
1 task
1 task
1 task
ghost
mentioned this pull request
1 task
1 task
This was referenced Nov 20, 2022
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Since the introduction of
CmdRunnerin April 2022, it should be preferred toCmdMixinand the derived classesCmdModuleHelperandCmdStateModuleHelper.This PR deprecates
CmdMixin.ISSUE TYPE
COMPONENT NAME
plugins/module_utils/mh/mixins/cmd.py