Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #5101/7777b48c backport][stable-5] New module: Proxmox disk management #5295

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Sep 18, 2022

This is a backport of PR #5101 as merged into main (7777b48).

SUMMARY

Add proxmox_disk module to provide management of virtual volumes in QEMU(KVM) virtual machines

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • proxmox_disk
ADDITIONAL INFORMATION

This module provides ability to manage disks in Proxmox VMs in such ways:

  • create disk (fresh new or import from existing image);
  • update disk (change some parameters, for example: iops limit, backup status);
  • move disk (between storages in one VM or to another VM);
  • grow size (shrinking not supported);
  • detach disk (leave it unused);
  • remove disk (permanently).

* New module: Proxmox disk management

* Remove misplaced option

* Type missed

* Fixed docs, quotes, 2.7 syntax

* Forgotten comma

* Version added 5.5.0

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* Italic options

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* Missed dot

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* Pythonify python

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* Shorten command

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* Action parameter drop. General improvements.

* Add proxmox_disk integration testing

* Shorten getting vmid

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* Code tag for value

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* Italic tag for option

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* Definite ID of the VM

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* Docs edit and loop condition

* Simplify conditions

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* Dropped bps options, added idempotency checks

* Documentaion edit

* Rewrite create/import condition

* Trainling comma

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* Added type field to all choosable arguments

* Description of disk bus ranges

* Fix imports

* Update version

Co-authored-by: Felix Fontein <felix@fontein.de>

* Lowercase YAML boolean

* Rename grown to resized and update documentation

* Documentation updated before actual changes

* Added 'update' flag for 'present' state

* Traling space

* YAML indentation

* Merged 'updated' option into 'present'.

* Doc update.

* Exclude 'import_from' on update

* Version bump

* yaml boolean lowercase

Co-authored-by: Felix Fontein <felix@fontein.de>

* yaml boolean lowercase

Co-authored-by: Felix Fontein <felix@fontein.de>

* More detailed description

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 7777b48)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport cloud integration tests/integration module module new_contributor Help guide this first time contributor new_plugin New plugin plugins plugin (any type) tests tests labels Sep 18, 2022
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

❗ No coverage uploaded for pull request base (stable-5@9dc2e2d). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 7777b48 differs from pull request most recent head 319af56. Consider uploading reports for the commit 319af56 to get more accurate results

@@             Coverage Diff             @@
##             stable-5    #5295   +/-   ##
===========================================
  Coverage            ?   45.43%           
===========================================
  Files               ?      978           
  Lines               ?    96183           
  Branches            ?    18329           
===========================================
  Hits                ?    43697           
  Misses              ?    50473           
  Partials            ?     2013           
Flag Coverage Δ
integration 71.29% <0.00%> (?)
sanity 21.25% <0.00%> (?)
stub 0.00% <0.00%> (?)
units 68.24% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@felixfontein felixfontein merged commit 96cda3a into stable-5 Sep 19, 2022
@felixfontein felixfontein deleted the patchback/backports/stable-5/7777b48c99c1a5ef5645fd42b8b50ab6182eef5d/pr-5101 branch September 19, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloud integration tests/integration module module new_contributor Help guide this first time contributor new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants