-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slack: add CP channel prefix #5249
Conversation
Unsolved root cause of issues is field |
Thanks for your contribution. Could you please add a changelog fragment? Also please fill out the PR form the next time instead of removing all the fields you find irrelevant. Thanks. |
@felixfontein Done! Sorry about not following the rules. I've also added a docs change for issue I've also stumbled upon and it wasn't described in the docs. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
SUMMARY
CP
#
symbol is being prependedmessage_id
is suppliedSUMMARY
CP
string was added to the list which describeschannel_id
prefixed for which#
symbol will be added in front ofchannel_id
channel_id
has to be literal Channel ID returned by previous task run.ISSUE TYPE
COMPONENT NAME
slack
ADDITIONAL INFORMATION
build_payload_for_slack
is called there is anif
which prepends#
ifchannel_id
starts with a certain symbols. I've stumbled upon a channel which ID starts withCP
but current implementation doesn't have this string in the list so I got#CPxxxxxx
added to payload.message_id
is supplied andchannel_id
is either "mychannel_nameor
#mychannel_nameit only works. When
channel_idis in form of
C0xxxxxxx` which is returned by previous task run.