Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception when agent argument is not specified. #5194

Merged
merged 1 commit into from
Aug 28, 2022
Merged

Fix exception when agent argument is not specified. #5194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/5194-fix-proxmox-agent-exception.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- "proxmox_kvm - fix exception when no ``agent`` argument is specified (https://github.com/ansible-collections/community.general/pull/5194)."
13 changes: 7 additions & 6 deletions plugins/modules/cloud/misc/proxmox_kvm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -963,12 +963,13 @@ def create_vm(self, vmid, newid, node, name, memory, cpu, cores, sockets, update
kwargs.update(kwargs[k])
del kwargs[k]

try:
# The API also allows booleans instead of e.g. `enabled=1` for backward-compatibility.
kwargs['agent'] = boolean(kwargs['agent'], strict=True)
except TypeError:
# Not something that Ansible would parse as a boolean.
pass
if 'agent' in kwargs:
try:
# The API also allows booleans instead of e.g. `enabled=1` for backward-compatibility.
kwargs['agent'] = boolean(kwargs['agent'], strict=True)
except TypeError:
# Not something that Ansible would parse as a boolean.
pass

# Rename numa_enabled to numa, according the API documentation
if 'numa_enabled' in kwargs:
Expand Down