Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WDC Redfish support for setting the power mode. #5145

Merged
merged 4 commits into from
Sep 3, 2022
Merged

WDC Redfish support for setting the power mode. #5145

merged 4 commits into from
Sep 3, 2022

Conversation

mikemoerk
Copy link
Contributor

@mikemoerk mikemoerk commented Aug 22, 2022 •
edited
Loading

SUMMARY

Support for setting enclosure power mode (low / normal) on WDC UltaStar Data102 storage enclosures.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

wdc_redfish_command

ADDITIONAL INFORMATION

Use category=Chassis, resource_id=Enclosure. New commands are PowerModeLow and PowerMode Normal. Example:

% ansible r13-mm1 -m community.general.wdc_redfish_command -a "username={{username}} password={{password}} baseuri={{ioms[0]}} category=Chassis resource_id=Enclosure command=PowerModeLow"
r13-mm1 | CHANGED => {
    "ansible_facts": {
        "discovered_interpreter_python": "/usr/local/bin/python3.8"
    },
    "changed": true,
    "msg": "Action was successful",
    "session": {}
}

@ansibullbot
Copy link
Collaborator

cc @Bhavya06 @mraineri @rajeevkallur @renxulei @tomasg2012 @xmadsen
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module module_utils module_utils plugins plugin (any type) remote_management tests tests unit tests/unit labels Aug 22, 2022
@github-actions
Copy link

github-actions bot commented Aug 22, 2022 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 labels Aug 22, 2022
felixfontein
felixfontein reviewed Aug 22, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Could you please add a changelog fragment? Thanks.

plugins/modules/remote_management/redfish/wdc_redfish_command.py Outdated Show resolved Hide resolved
tests/unit/plugins/modules/remote_management/wdc/test_wdc_redfish_command.py Outdated Show resolved Hide resolved
mikemoerk and others added 2 commits August 22, 2022 14:22
@mikemoerk @felixfontein
Apply suggestions from code review
6cdb97b 
Co-authored-by: Felix Fontein <felix@fontein.de>
@mikemoerk
Add change fragment.
b154c4b
@mikemoerk
Copy link
Contributor Author

@felixfontein , apologies for the delay -- I have added the changelog fragment as requested.

@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Aug 29, 2022
@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Aug 30, 2022
@felixfontein felixfontein merged commit 2a449eb into ansible-collections:main Sep 3, 2022
@patchback
Copy link

patchback bot commented Sep 3, 2022 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/2a449eb16329b180555042473e751995b7d29c96/pr-5145

Backported as #5223

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Sep 3, 2022
patchback bot pushed a commit that referenced this pull request Sep 3, 2022
@mikemoerk @patchback
WDC Redfish support for setting the power mode. (#5145)
3599173 
* WDC Redfish support for setting the power mode.

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* Add change fragment.

* Add extension to changelog fragment.

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 2a449eb)
@patchback patchback bot mentioned this pull request Sep 3, 2022
Merged
@felixfontein
Copy link
Collaborator

@mikemoerk thanks for contributing this!

This was referenced Nov 20, 2022
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
Open
Closed
@renovate renovate bot mentioned this pull request Dec 14, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Jan 1, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request module_utils module_utils module module plugins plugin (any type) remote_management tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikemoerk @ansibullbot @felixfontein