[PR #5129/3c2d7eb1 backport][stable-5] dig: Fix evaluation of boolean parameters #5137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
* Add lookup_dig tests * Fix boolean evaluation * Add changelog fragment * Apply review changes * Add license (cherry picked from commit 3c2d7eb)
ansibullbot
added
backport
bug
felixfontein
deleted the
patchback/backports/stable-5/3c2d7eb193ac6676a054396c2d41328f23862104/pr-5129
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #5129 as merged into main (3c2d7eb).
SUMMARY
Fixes evaluation of falsy boolean parameters in dig lookup plugin.
ISSUE TYPE
COMPONENT NAME
community.general.dig lookup plugin
ADDITIONAL INFORMATION
Plugin currently uses
bool()function to convert string boolean values to boolean type. This function in not the right one for this task as is returnsTruefor every non-empty string:There is function in ansible.module_utils for this which correctly handles string-to-boolean conversion.
I also added tests for dig lookup and this issue specifically.