Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WDC Redfish firmware update support for update image creds #5056

Merged
merged 1 commit into from
Aug 2, 2022
Merged

WDC Redfish firmware update support for update image creds #5056

merged 1 commit into from
Aug 2, 2022

Conversation

mikemoerk
Copy link
Contributor

SUMMARY

Allows user to specify Basic Auth credentials for firmware update image.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

wdc_redfish_command

ADDITIONAL INFORMATION

Fix to support basic auth credentials for firmware update image.

Example that was not working before:

ansible  mm4 -m community.general.wdc_redfish_command -e '{"update_creds": {"username": "user", "password": "password"}}' -a "username={{ user }} password={{ pass }} ioms={{ ioms }}  category=Update command=UpdateAndActivate update_creds={{ update_creds }} update_image_uri=http://example.com:8088/bundle4_0_10ST.tar.gz"

@mikemoerk
WDC Redfish firmware update support for update image creds
d00c2da 
Allows user to specify Basic Auth credentials for firmware update image.
@ansibullbot ansibullbot added bug This issue/PR relates to a bug module_utils module_utils plugins plugin (any type) labels Aug 1, 2022
felixfontein
felixfontein approved these changes Aug 2, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this hasn't been in a release, this must not have a changelog fragment. Since you are maintaining this code I'm assuming you properly tested this :)

@felixfontein felixfontein merged commit 4eb3540 into ansible-collections:main Aug 2, 2022
@patchback
Copy link

patchback bot commented Aug 2, 2022 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/4eb3540c8e98137d15efb07763ebbf3f47b3b2fc/pr-5056

Backported as #5057

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@mikemoerk thanks for this fix!

patchback bot pushed a commit that referenced this pull request Aug 2, 2022
@mikemoerk @patchback
WDC Redfish firmware update support for update image creds (#5056)
d05e15f 
Allows user to specify Basic Auth credentials for firmware update image.

(cherry picked from commit 4eb3540)
@patchback patchback bot mentioned this pull request Aug 2, 2022
Merged
felixfontein pushed a commit that referenced this pull request Aug 2, 2022
@patchback @mikemoerk
WDC Redfish firmware update support for update image creds (#5056) (#…
a81e94d 
…5057)

Allows user to specify Basic Auth credentials for firmware update image.

(cherry picked from commit 4eb3540)

Co-authored-by: Mike <michael.moerk@wdc.com>
bratwurzt pushed a commit to bratwurzt/community.general that referenced this pull request Nov 7, 2022
@mikemoerk
WDC Redfish firmware update support for update image creds (ansible-c…
bb989d1 
…ollections#5056)

Allows user to specify Basic Auth credentials for firmware update image.
bratwurzt pushed a commit to bratwurzt/community.general that referenced this pull request Nov 7, 2022
@mikemoerk
WDC Redfish firmware update support for update image creds (ansible-c…
43a5dbf 
…ollections#5056)

Allows user to specify Basic Auth credentials for firmware update image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug module_utils module_utils plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikemoerk @felixfontein @ansibullbot