-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up deprecations #504
Clean up deprecations #504
Conversation
…uiltin_runtime.yml
…ng to ansible/ansible's ansible_builtin_runtime.yml.
… used by one lookup. Mark as deprecated/internal.
@felixfontein This PR was evaluated as a potentially problematic PR for the following reasons:
Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: |
I used https://gist.github.com/felixfontein/964068eed7e8d233f77abe097eef31a7 to clean up meta/runtime.yml and remove some modules that have apparently been moved somewhere else meanwhile. |
cbb98b0
to
110405f
Compare
110405f
to
2a36f25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found something in your branch about deprecations among other things in the output below (this is all stuff containing Ansible 2.X which is still there, maybe better to change them as well?)
plugins/lookup/hashi_vault.py: - As of Ansible 2.10, only the latest version of a secret is returned when specifying a KV v2 path.
plugins/lookup/hashi_vault.py: - As of Ansible 2.10, all options can be supplied via term string (space delimited key=value pairs) or by parameters (see examples).
plugins/lookup/hashi_vault.py: - As of Ansible 2.10, when C(secret) is the first option in the term string, C(secret=) is not required (see examples).
plugins/lookup/hashi_vault.py: - C(aws_iam_login) is added in Ansible 2.10.
plugins/lookup/hashi_vault.py: - C(dict) returns a single dict containing the key/value pairs (same behavior as before Ansible 2.10).
plugins/lookup/hashi_vault.py:# The following examples work in collection releases after Ansible 2.10
plugins/modules/cloud/smartos/vmadm.py: - Type of virtual machine. The C(bhyve) option was added in Ansible 2.10.
plugins/modules/database/mysql/mysql_replication.py: C(resetmaster) (RESET MASTER) - supported from Ansible 2.10,
plugins/modules/database/postgresql/postgresql_privs.py:# Available since Ansible 2.10
plugins/modules/database/postgresql/postgresql_privs.py:# Available since Ansible 2.10
plugins/modules/files/archive.py: # The path argument is only supported in Ansible 2.10+. Fall back to
plugins/modules/monitoring/datadog/datadog_monitor.py: - C(message) alias is deprecated in Ansible 2.10, since it is used internally by Ansible Core Engine.
plugins/modules/monitoring/airbrake_deployment.py: - Parameter I(token) has been deprecated for Ansible 2.10. Please remove entry.
plugins/modules/monitoring/airbrake_deployment.py: - This parameter (API token) has been deprecated in Ansible 2.10. Please remove it from your tasks.
plugins/modules/monitoring/bigpanda.py: - C(message) alias is deprecated in Ansible 2.10, since it is used internally by Ansible Core Engine.
plugins/modules/net_tools/ldap/ldap_attr.py: alternative: 'Use M(ldap_attrs) instead. Deprecated in Ansible 2.10.'
plugins/modules/source_control/gitlab/gitlab_user.py: - From Ansible 2.10 and onwards, name, email and password are optional while deleting the user.
plugins/modules/packaging/os/pulp_repo.py: The ca_cert alias will be removed in Ansible 2.14.
plugins/modules/packaging/os/pulp_repo.py: change in Ansible 2.14.
plugins/modules/packaging/os/pulp_repo.py: change in Ansible 2.14.
plugins/modules/packaging/os/pulp_repo.py: "Ansible 2.9.2). Until Ansible 2.14, the default value for `feed_client_cert` will be taken from "
I think the Ansible 2.10 texts can stay, because they are helpful to users (whatever the texts say has been around in the collection since the first proper release, i.e. 0.2.0, but it wasn't there in Ansible 2.9). For the others I'll have to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
This adjusts the deprecation versions as decided in the community working group meeting (https://meetbot.fedoraproject.org/ansible-community/2020-06-10/community_working_group.2020-06-10-18.04.html), and adjusts the ignore.txt entries.
Removes some meta/runtime.yml entries that point to modules/plugins that do not exist in this collection, remove some symlinks that are already redirected to the correct target in ansible/ansible's ansible_builtin_runtime.yml, and clean up a bit more.
ISSUE TYPE
COMPONENT NAME
collection