Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible_galaxy_install: minor improvements based on MH updates #4752

Merged
merged 2 commits into from
Jun 4, 2022
Merged

ansible_galaxy_install: minor improvements based on MH updates #4752

merged 2 commits into from
Jun 4, 2022

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented May 30, 2022

SUMMARY

Minor refactorings based on the latests updates in ModuleHelper.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/packaging/language/ansible_galaxy_install.py

@ansibullbot ansibullbot added bug This issue/PR relates to a bug language module module packaging plugins plugin (any type) small_patch Hopefully easy to review labels May 30, 2022
@ansibullbot ansibullbot removed the small_patch Hopefully easy to review label May 30, 2022
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 labels May 30, 2022
@felixfontein felixfontein merged commit d019e22 into ansible-collections:main Jun 4, 2022
@patchback
Copy link

patchback bot commented Jun 4, 2022 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/d019e22e7db36815595a389497003120cdf79efe/pr-4752

Backported as #4774

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 4, 2022
@russoz @patchback
ansible_galaxy_install: minor improvements based on MH updates (#4752)
507fb2c 
* ansible_galaxy_install: minor improvements based on MH updates

* added changelog fragment

(cherry picked from commit d019e22)
@patchback patchback bot mentioned this pull request Jun 4, 2022
Merged
@felixfontein
Copy link
Collaborator

@russoz thanks these improvements!

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jun 4, 2022
@russoz russoz deleted the ansible-galaxy-install-mh-updates branch June 4, 2022 09:57
felixfontein pushed a commit that referenced this pull request Jun 6, 2022
@patchback @russoz
ansible_galaxy_install: minor improvements based on MH updates (#4752) (
69c79f6 
#4774)

* ansible_galaxy_install: minor improvements based on MH updates

* added changelog fragment

(cherry picked from commit d019e22)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
@trux-bot trux-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
@lumiere-bot lumiere-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
@ergho-bot ergho-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
@angelnu-bot angelnu-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
@ghost ghost mentioned this pull request Nov 7, 2022
Merged
1 task
@feisar-bot feisar-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
@iudicael-bot iudicael-bot bot mentioned this pull request Nov 7, 2022
Closed
1 task
@chamburr-bot chamburr-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
@bloopy-boi bloopy-boi bot mentioned this pull request Nov 7, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Nov 7, 2022
Closed
1 task
This was referenced Nov 20, 2022
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
Open
Closed
@renovate renovate bot mentioned this pull request Dec 14, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Jan 1, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug language module module packaging plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russoz @felixfontein @ansibullbot