Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lenovoxcc module for compatibility with the virtualMedia resource location from Manager to System #4682

Merged
merged 3 commits into from
May 18, 2022
Merged

Update lenovoxcc module for compatibility with the virtualMedia resource location from Manager to System #4682

merged 3 commits into from
May 18, 2022

Conversation

jixj5
Copy link
Contributor

@jixj5 jixj5 commented May 17, 2022

SUMMARY

Update xcc_redfish_command module for compatibility due to redfish spec changes the virtualMedia resource location from Manager to System.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

xcc_redfish_command

@panyy3
Update lenovoxcc module for compatibility due to redfish spec changes…
e16ee3f 
… the virtualMedia resource location from Managers to Systems
@ansibullbot
Copy link
Collaborator

cc @panyy3 @renxulei
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type) remote_management tests tests unit tests/unit labels May 17, 2022
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-4 labels May 17, 2022
@jixj5 jixj5 closed this May 17, 2022
@jixj5 jixj5 reopened this May 17, 2022
panyy3
panyy3 approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@panyy3 panyy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are OK from my side.

@jixj5 @felixfontein
Update changelogs/fragments/4682-compatibility-virtualmedia-resource-…
e27b5ef 
…location.yaml

Co-authored-by: Felix Fontein <felix@fontein.de>
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label May 18, 2022
@felixfontein felixfontein merged commit 8db265f into ansible-collections:main May 18, 2022
@patchback
Copy link

patchback bot commented May 18, 2022 •
edited
Loading

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/8db265f99b4b0d2d4e2b1c339d3a787ed7c9d806/pr-4682

Backported as #4684

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 18, 2022
@jixj5 @patchback
Update lenovoxcc module for compatibility with the virtualMedia resou…
d3b3e75 
…rce location from Manager to System (#4682)

* Update lenovoxcc module for compatibility due to redfish spec changes the virtualMedia resource location from Managers to Systems

* Add changelogs fragment for PR 4682

* Update changelogs/fragments/4682-compatibility-virtualmedia-resource-location.yaml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Tami YY3 Pan <panyy3@lenovo.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 8db265f)
@patchback patchback bot mentioned this pull request May 18, 2022
Merged
@patchback
Copy link

patchback bot commented May 18, 2022 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/8db265f99b4b0d2d4e2b1c339d3a787ed7c9d806/pr-4682

Backported as #4685

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 18, 2022
@jixj5 @patchback
Update lenovoxcc module for compatibility with the virtualMedia resou…
01474ba 
…rce location from Manager to System (#4682)

* Update lenovoxcc module for compatibility due to redfish spec changes the virtualMedia resource location from Managers to Systems

* Add changelogs fragment for PR 4682

* Update changelogs/fragments/4682-compatibility-virtualmedia-resource-location.yaml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Tami YY3 Pan <panyy3@lenovo.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 8db265f)
@patchback patchback bot mentioned this pull request May 18, 2022
Merged
@felixfontein
Copy link
Collaborator

@jixj5 thanks for fixing this!
@panyy3 thanks for reviewing!

felixfontein pushed a commit that referenced this pull request May 18, 2022
@patchback @jixj5
Update lenovoxcc module for compatibility with the virtualMedia resou…
5dde703 
…rce location from Manager to System (#4682) (#4684)

* Update lenovoxcc module for compatibility due to redfish spec changes the virtualMedia resource location from Managers to Systems

* Add changelogs fragment for PR 4682

* Update changelogs/fragments/4682-compatibility-virtualmedia-resource-location.yaml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Tami YY3 Pan <panyy3@lenovo.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 8db265f)

Co-authored-by: jixj5 <66418293+jixj5@users.noreply.github.com>
felixfontein pushed a commit that referenced this pull request May 18, 2022
@patchback @jixj5
Update lenovoxcc module for compatibility with the virtualMedia resou…
056e16b 
…rce location from Manager to System (#4682) (#4685)

* Update lenovoxcc module for compatibility due to redfish spec changes the virtualMedia resource location from Managers to Systems

* Add changelogs fragment for PR 4682

* Update changelogs/fragments/4682-compatibility-virtualmedia-resource-location.yaml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Tami YY3 Pan <panyy3@lenovo.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 8db265f)

Co-authored-by: jixj5 <66418293+jixj5@users.noreply.github.com>
@jixj5 jixj5 deleted the update_lenovoxcc_virtualMedia branch May 18, 2022 08:30
This was referenced Nov 20, 2022
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
Open
Closed
@renovate renovate bot mentioned this pull request Dec 14, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Jan 1, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

@panyy3 panyy3 panyy3 approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type) remote_management tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jixj5 @ansibullbot @felixfontein @panyy3