Multiple modules using ModuleHelper #4674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced raising exception with calling method do_raise() in MH. Removed the importing of the exception class.
felixfontein
added
the
check-before-release
ansibullbot
added
feature
felixfontein
approved these changes
May 23, 2022
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #4713 🤖 @patchback |
|
@russoz thanks! |
patchback bot
pushed a commit
that referenced
this pull request
May 23, 2022
* Multiple modules using ModuleHelper Replaced raising exception with calling method do_raise() in MH. Removed the importing of the exception class. * added changelog fragment (cherry picked from commit 6052776)
felixfontein
pushed a commit
that referenced
this pull request
May 23, 2022
* Multiple modules using ModuleHelper Replaced raising exception with calling method do_raise() in MH. Removed the importing of the exception class. * added changelog fragment (cherry picked from commit 6052776) Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
felixfontein
removed
the
check-before-release
1 task
1 task
1 task
1 task
ghost
mentioned this pull request
1 task
1 task
1 task
1 task
This was referenced Nov 20, 2022
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Replaced raising exception with calling method do_raise() in MH.
Removed the importing of the exception class.
ISSUE TYPE
COMPONENT NAME
plugins/modules/packaging/language/cpanm.py
plugins/modules/packaging/language/pipx.py
plugins/modules/packaging/os/snap.py
plugins/modules/system/mksysb.py
plugins/modules/system/xfconf.py