Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nmcli: Disallow Wi-Fi options not supported by nmcli #3141

Merged
merged 34 commits into from
Aug 20, 2021
Merged

nmcli: Disallow Wi-Fi options not supported by nmcli #3141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
966790f
nmcli: Disallow Wi-Fi options not supported by nmcli
hummeltech Aug 7, 2021
d1f9e6a
Added changelog fragment
hummeltech Aug 7, 2021
a74aabd
Added tests
hummeltech Aug 8, 2021
09e9d2c
Simplify `get_available_options()`
hummeltech Aug 8, 2021
53bdba9
Update changelogs/fragments/3141-disallow-options-unsupported-by-nmcl…
hummeltech Aug 8, 2021
099d831
Remove redundant `802-11-wireless` settings from test show outputs
hummeltech Aug 8, 2021
c45c53b
Update `mocked_wireless_create(mocker)`
hummeltech Aug 8, 2021
12c4b65
Update plugins/modules/net_tools/nmcli.py
hummeltech Aug 9, 2021
245a7ed
Address comment re. creating function & use nmcli naming conventions
hummeltech Aug 14, 2021
62aa003
Added `ignore_unsupported_suboptions` option & improved `wifi(_sec)` doc
hummeltech Aug 14, 2021
e2c0dd9
Corrected pep8 issues
hummeltech Aug 14, 2021
74fcc19
Fixed remaining sanity check issues and added even more docs
hummeltech Aug 15, 2021
52d3f71
No need to split Note
hummeltech Aug 15, 2021
c1e1ac2
Update plugins/modules/net_tools/nmcli.py
hummeltech Aug 15, 2021
c8c8a5b
Followed uniformity guideline for format macros from Ansible's dev guide
hummeltech Aug 15, 2021
d91f6d3
Addressed comment
hummeltech Aug 15, 2021
c783ec3
Documentation cleanup continuation
hummeltech Aug 15, 2021
880abb4
Replace `NM_SETTING_*`s having a description with their numeric value
hummeltech Aug 15, 2021
6869e73
Splitting up long paragraphs.
hummeltech Aug 15, 2021
296e6ad
Addressed remaining comments and clarified `wake-on-lan` note
hummeltech Aug 15, 2021
d1c2c29
Update plugins/modules/net_tools/nmcli.py
hummeltech Aug 17, 2021
a614a71
Update plugins/modules/net_tools/nmcli.py
hummeltech Aug 17, 2021
aed5cb5
Update plugins/modules/net_tools/nmcli.py
hummeltech Aug 17, 2021
bda5e3d
Update plugins/modules/net_tools/nmcli.py
hummeltech Aug 17, 2021
df2016c
Finishing addressing documentation comments.
Aug 17, 2021
9148e38
Update plugins/modules/net_tools/nmcli.py
hummeltech Aug 17, 2021
41b51a2
Update plugins/modules/net_tools/nmcli.py
hummeltech Aug 17, 2021
13a51f3
Update nmcli.py
hummeltech Aug 17, 2021
f575479
Added wifi-related `list` type options to `settings_type` method
hummeltech Aug 20, 2021
b46eb00
Moved `edit_commands` `execution` logic into its own method
hummeltech Aug 20, 2021
c169fe4
Move `unsupported_property` deletion into `main` function
hummeltech Aug 20, 2021
94c546a
Missing `.items()`
hummeltech Aug 20, 2021
9c07790
Resolved missing proper `nmcli conn edit` arguments
hummeltech Aug 20, 2021
c8658a2
Resolve pylint issue `dangerous-default-value`
hummeltech Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelogs/fragments/3141-disallow-options-unsupported-by-nmcli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
minor_changes:
- nmcli - query ``nmcli`` directly to determine available WiFi options
(https://github.com/ansible-collections/community.general/pull/3141).
Loading