Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define python_requires for ansible-test #349

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Define python_requires for ansible-test #349

merged 2 commits into from
Jan 26, 2024

Conversation

mamercad
Copy link
Collaborator

Fixes #347.

@mamercad mamercad marked this pull request as ready for review January 25, 2024 17:02
@mamercad mamercad mentioned this pull request Jan 25, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Jan 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (62f419e) 64.03% compared to head (5bed5ee) 30.71%.

❗ Current head 5bed5ee differs from pull request most recent head 7be029d. Consider uploading reports for the commit 7be029d to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #349       +/-   ##
===========================================
- Coverage   64.03%   30.71%   -33.32%     
===========================================
  Files          46       46               
  Lines        3617     3617               
  Branches      743      743               
===========================================
- Hits         2316     1111     -1205     
- Misses        995     2483     +1488     
+ Partials      306       23      -283
Flag Coverage Δ
integration ?
sanity 26.01% <ø> (ø)
units 60.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mamercad @gotmax23
Update changelogs/fragments/347-ansible-test-python-requires.yml
7be029d 
Co-authored-by: Maxwell G <maxwell@gtmx.me>
@mamercad mamercad merged commit 6f2122a into main Jan 26, 2024
1 check passed
@mamercad mamercad deleted the issue-347-2 branch January 26, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gotmax23 gotmax23 gotmax23 left review comments

@Akasurde Akasurde Awaiting requested review from Akasurde Akasurde is a code owner

@bmildren bmildren Awaiting requested review from bmildren bmildren is a code owner

@danxg87 danxg87 Awaiting requested review from danxg87 danxg87 is a code owner

@geerlingguy geerlingguy Awaiting requested review from geerlingguy geerlingguy is a code owner

@mpontillo mpontillo Awaiting requested review from mpontillo mpontillo is a code owner

@tparker00 tparker00 Awaiting requested review from tparker00 tparker00 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Community package requirements: sanity tests
2 participants
@mamercad @gotmax23